Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support optionally automatically converting :P into 😛 etc #2567

Closed
4nd3r opened this issue Nov 10, 2016 · 11 comments
Closed

support optionally automatically converting :P into 😛 etc #2567

4nd3r opened this issue Nov 10, 2016 · 11 comments

Comments

@4nd3r
Copy link
Contributor

4nd3r commented Nov 10, 2016

translate :P :D :) :| etc to emojis

@aperezdc
Copy link

aperezdc commented Nov 14, 2016

One of the things I like about Riot is that

scp foo.png host:public_html/

does not get translated into

scp foo.png host 😛 ublic_html/

Automatically translating the first into the second is something I am definitely not looking forward to. If anything, automatic translation should be either 1.) an opt-in setting, or 2.) undoable.

@ara4n
Copy link
Member

ara4n commented Nov 15, 2016

this can be handled nicely in RTE by offering the emoji as an autocomplete option - which is hiding in #1761 (comment)

@ara4n ara4n closed this as completed Nov 15, 2016
@ara4n
Copy link
Member

ara4n commented Nov 15, 2016

(closing as dup)

@4nd3r
Copy link
Contributor Author

4nd3r commented Nov 15, 2016

scp foo.png host 😛 ublic_html/

this is a classic case of shitty regex. we have \s and \b for this kind of cases.

facebook somehow manages to do it...

@ara4n
Copy link
Member

ara4n commented Apr 2, 2017

this comes up fairly regularly as people ask if we can automatically do the substitution... as an option. so reopening this to be the canonical bug for that.

@ara4n ara4n reopened this Apr 2, 2017
@ara4n ara4n changed the title support classical emoticons support optionally automatically converting :P into 😛 etc Apr 2, 2017
@jasuarez
Copy link

jasuarez commented May 3, 2017

One of the things I like about Riot is that

scp foo.png host:public_html/
does not get translated into

scp foo.png host 😛 ublic_html/

One way to avoid this could be if the conversion is done only if there's a white before the emoticon. I think that would solve 95% of cases.

We could also request another white after the emoticon, or an EOL.

@simm3
Copy link

simm3 commented May 20, 2017

I'd also like to suggest a "mapping" feature. Most of the emojis are very ugly (at least in Chrome under Linux). Also most (if not all) emoticons are not animated.

So it would be nice if there could be an (optional?) mapping between emoticon code and emoticon URL. Example emoticons: http://www.smiley-paradies.de/animierte-smileys/liebe.html

So if he defined it before, one could write :dance: (or whatever the code is) and riot.im users will see this emoticon: http://www.smiley-paradies.de/smileys/tanzend/tanzend_0014.gif

Mibbit has this: http://web20chat.wdfiles.com/local--files/chat%3Amibbit/mibbit-9.png

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jul 4, 2017

So this is done but is slightly buggy but stuff like :) *tab* results in 🙂 and <3 *tab*, ❤️ etc. One issue is that the close-ness of the match is not considered, so :) will actually complete to 😅 before 😄 or 🙂.

@kethinov
Copy link

kethinov commented Jul 4, 2017

Would be nice to:

  • Map the defaults better (e.g. how hangouts does it)
  • Have a setting to do it automatically (without having to force it using tab)

Should we file a separate issue for that?

@lukebarnard1
Copy link
Contributor

@kethinov two separate issues for those would be much appreciated, and a quick description of how hangouts does it would be great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants