Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Border on quotes is invisible #25782

Closed
robintown opened this issue Jul 12, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11251
Closed

Border on quotes is invisible #25782

robintown opened this issue Jul 12, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11251
Assignees
@germain-gg
Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker

Comments

@robintown
Copy link
Member

Steps to reproduce

  1. Send a message with a block quote, like "> test"

Outcome

What did you expect?

There should be a vertical line on the edge of the quote

What happened instead?

There is no vertical line. There's a border-left attribute present in the CSS, but it's invisible due to an invalid color.

Screenshot 2023-07-12 at 16-03-54 Element 13 Test room

Operating system

NixOS unstable

Browser information

Firefox 114.0.1

URL for webapp

develop.element.io

Application version

Element version: da0b658-react-38d24f164a46-js-b186d79dde28 Olm version: 3.2.14

Homeserver

Not relevant

Will you send logs?

No
@robintown robintown added T-Defect X-Regression S-Minor Impairs non-critical functionality or suitable workarounds exist A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jul 12, 2023
@robintown
Copy link
Member Author

cc @germain-gg

@germain-gg germain-gg self-assigned this Jul 13, 2023
@germain-gg germain-gg mentioned this issue Jul 13, 2023
Merged
3 tasks
@t3chguy t3chguy mentioned this issue Jul 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@germain-gg germain-gg

Labels
A-Timeline O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix color mapping for blockquote border matrix-org/matrix-react-sdk
3 participants
@germain-gg @t3chguy @robintown