Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification count is doubled in e2ee rooms on startup #25803

Closed
germain-gg opened this issue Jul 14, 2023 · 3 comments · Fixed by matrix-org/matrix-js-sdk#3634 or matrix-org/matrix-js-sdk#3640
Closed

Notification count is doubled in e2ee rooms on startup #25803

germain-gg opened this issue Jul 14, 2023 · 3 comments · Fixed by matrix-org/matrix-js-sdk#3634 or matrix-org/matrix-js-sdk#3640
Assignees
@t3chguy
Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@germain-gg
Copy link
Contributor

Steps to reproduce

  1. Have bob send you 5 messages
  2. See the unread count as 5 in the roomlist, and wait for the sync accumulator to be flushed in idb
  3. Close Element and re-open it

Outcome

What did you expect?

For the unread count to show a count of 5

What happened instead?

The unread count is now 10.

I suspect the fixNotificationCountOnDecryption function has regressed. Upon decrypting an event it should adjust the notification count accordingly to not have doubled notification count like the one im experiencing

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@Johennes Johennes mentioned this issue Jul 24, 2023
Open
@weeman1337
Copy link
Contributor

weeman1337 commented Jul 25, 2023 •
edited
Loading

Can easily reproduce this. Had to repeat the send message and reload steps two times.

@weeman1337 weeman1337 added A-Notifications S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience X-Regression labels Jul 25, 2023
@t3chguy t3chguy mentioned this issue Jul 26, 2023
Closed
@kittykat
Copy link
Contributor

I can reproduce while looking at Element in a browser tab. The count just appears as two new messages in the left panel instead of one.

@t3chguy
Copy link
Member

t3chguy commented Jul 28, 2023

Regressed by matrix-org/matrix-js-sdk#3130

@t3chguy t3chguy self-assigned this Jul 28, 2023
@t3chguy t3chguy mentioned this issue Jul 28, 2023
Merged
@t3chguy t3chguy mentioned this issue Jul 31, 2023
Merged
@t3chguy t3chguy reopened this Jul 31, 2023
@t3chguy t3chguy mentioned this issue Jul 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-Notifications O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Milestone
No milestone
4 participants
@kittykat @germain-gg @t3chguy @weeman1337