Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element stops asking for history if it's full of reactions #25873

Open
timokoesters opened this issue Jul 29, 2023 · 3 comments
Open

Element stops asking for history if it's full of reactions #25873

timokoesters opened this issue Jul 29, 2023 · 3 comments
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Blocked

Comments

@timokoesters
Copy link

Steps to reproduce

Join a room with a lot of reactions after another.

In my testing I used the bug from #25872

Outcome

image

Sometimes it is also stuck showing a spinner.

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No
@t3chguy
Copy link
Member

t3chguy commented Jul 31, 2023

image

Toggling canBackPaginate a couple of times caused more history to load :D

image

@t3chguy
Copy link
Member

t3chguy commented Jul 31, 2023 •
edited
Loading

Looks like the issue is due to Element dropping the events due to not knowing what timeline (main or thread) they belong to
so then other code assumes the server messed up and didn't send us any events and gave up
this won't be an easy fix unfortunately

matrix-org/matrix-spec-proposals#4023 would make this problem go away

Edit:
this can also happen even if the MSC lands with threads until we have a filter for backpaginating excluding threads - matrix-org/matrix-spec-proposals#3874

So the proper fix requires both MSC4023 and MSC3874

This was referenced Jul 31, 2023
Merged
Merged
@t3chguy
Copy link
Member

t3chguy commented Jul 31, 2023

The above PRs are workarounds until the MSCs have wide availability

@germain-gg germain-gg added S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Timeline O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Blocked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@germain-gg @t3chguy @timokoesters