Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending markdown with a horizontal rule does not work with rich text editor #25954

Open
weeman1337 opened this issue Aug 11, 2023 · 3 comments
Open

Sending markdown with a horizontal rule does not work with rich text editor #25954

weeman1337 opened this issue Aug 11, 2023 · 3 comments
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Labs

Comments

@weeman1337
Copy link
Contributor

weeman1337 commented Aug 11, 2023 •
edited
Loading

Steps to reproduce

  1. Enable rich text editor in labs
  2. Open any room
  3. Turn composer formatting off image
  4. Send
This is
---
a test

Outcome

What did you expect?

Message send

What happened instead?

Message not send

Error in console:

MessageComposer.tsx:351 Uncaught (in promise) could not create dom from html

Operating system

No response

Application version

Element Nightly version: 2023081001 Olm version: 3.2.14

How did you install the app?

No response

Homeserver

No response

Will you send logs?

Yes
@weeman1337 weeman1337 added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow Z-Labs A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor labels Aug 11, 2023
@manancodes
Copy link

I do not see rich text editor in labs, is it removed?
If it is removed, this issue is irrelevant.

@t3chguy
Copy link
Member

t3chguy commented Oct 11, 2023

@manancodes nope it is still there, you need to have full labs enabled, like on develop.element.io

@manancodes
Copy link

The function plainToRich seems to be causing the problem.(Link)

  • If I remove the function and use message directly, the message is sent, but that is obviously not the solution. (Mentions don't render, possibly other problems as well)
  • In the file there is a comment // TODO markdown support which I think suggests that the implementation is not complete.
  • The matrix-wysiwyg-composer-swift library is written in swift which I am not familiar with.

Do you have any suggestions on how to approach this problem?

@spantaleev spantaleev mentioned this issue Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Rich-Text-Editor Issues with the new rich text editor, also known as the WYSIWYG editor O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Z-Labs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@t3chguy @weeman1337 @manancodes