Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EW: Direct to MAS for sign-out in OIDC-aware mode #26000

Closed
Tracked by #1492
hughns opened this issue Aug 18, 2023 · 3 comments · Fixed by matrix-org/matrix-react-sdk#11432
Closed
Tracked by #1492

EW: Direct to MAS for sign-out in OIDC-aware mode #26000

hughns opened this issue Aug 18, 2023 · 3 comments · Fixed by matrix-org/matrix-react-sdk#11432

Comments

@hughns
Copy link
Member

hughns commented Aug 18, 2023

In the case of OIDC-aware clients, you cannot sign out of other sessions via the device manager in EW anymore. Instead, users will need to be guided towards the MAS UI to take this actions.

MSC3824 now describes this requirement and proposes the convention of ?action=session_end&device_id=<device_id>.

ACs

  • When the HS has a MAS deployment configured:
    • Clicking the sign-out button in the EW device manager for sessions other than the current redirects to MAS
    • There is an interstitial dialog that explains that the user will be redirected to perform the action on MAS
    • The redirection lands the user on a deep-link (query hash as per the MSC)
    • Multi-session signout is disabled
  • Otherwise, things stay as they are
@Johennes Johennes changed the title Session manager sign out behaviour in OIDC-aware mode Direct to MAS for sign-out in OIDC-aware mode Aug 18, 2023
@Johennes Johennes changed the title Direct to MAS for sign-out in OIDC-aware mode EW: Direct to MAS for sign-out in OIDC-aware mode Aug 18, 2023
@kerryarchibald
Copy link
Contributor

EW doesn't currently have a way to open settings/device manager using a URL. Will MAS redirect after sign out is complete?

@hughns
Copy link
Member Author

hughns commented Aug 21, 2023

EW doesn't currently have a way to open settings/device manager using a URL. Will MAS redirect after sign out is complete?

There is no redirection after the user takes an action.

For Element Web I suggest that the URL is opened in a new tab (e.g. target="_blank").

For Element Desktop where I don't believe we have an in-app browser I suggest that the URL is opened in the native browser.

@hughns
Copy link
Member Author

hughns commented Aug 22, 2023

FYI - MAS is stripping the query params when doing it's redirect from /account to /account/ which might hamper testing. But if you right click and inspect the URL that EW has created it looks good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants