Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New room header buttons not using styled tooltips #26096

Closed
t3chguy opened this issue Sep 1, 2023 · 7 comments
Closed

New room header buttons not using styled tooltips #26096

t3chguy opened this issue Sep 1, 2023 · 7 comments
Labels
A-Tooltips Anything related to tooltips O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Regression Z-Compound

Comments

@t3chguy
Copy link
Member

t3chguy commented Sep 1, 2023

Steps to reproduce

  1. Enable labs flag
  2. Find a room where you lack permission to call
  3. Hover over disabled icons

Outcome

The new room header UI is sleek but has a major usability regression around tooltips. Using the native title attribute instead of tooltips is fine for accessible technologies but not great for sighted users having to hover for ~5s for the tiny tooltip to appear

What did you expect?

image

What happened instead?

image

Operating system

No response

Browser information

No response

URL for webapp

No response

Application version

No response

Homeserver

No response

Will you send logs?

No

@dbkr dbkr added S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-Tooltips Anything related to tooltips labels Sep 7, 2023
@germain-gg
Copy link
Contributor

https://www.radix-ui.com/primitives/docs/components/tooltip#displaying-a-tooltip-from-a-disabled-button being the solution to this. We need to figure out whether we can encompass that directly in the Tooltip component in Compound Web, as this sounds like a fairly common thing to happen

@Johennes Johennes added Help Wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ labels Nov 8, 2023
@Aziz-4980
Copy link

is this issue still open? @t3chguy

@t3chguy
Copy link
Member Author

t3chguy commented Nov 13, 2023

image

@Aziz-4980 yup.

@lalitkumawat1m
Copy link

I want to work on this issue please assign it to me

@t3chguy
Copy link
Member Author

t3chguy commented Nov 16, 2023

Thank you for your interest in this issue. We will normally not assign the issue to an external contributor until they have provided at least a draft PR which is taking the right direction. For further details, see our guidance on assigning issues.

If you have any technical questions about this issue, you can ask for help in #element-dev:matrix.org

@kerryarchibald kerryarchibald self-assigned this Nov 17, 2023
@kerryarchibald kerryarchibald removed Help Wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest Issues which are suitable for Hacktoberfest PRs: https://hacktoberfest.digitalocean.com/ labels Nov 17, 2023
@github-actions github-actions bot removed the Z-Labs label Nov 17, 2023
@daniellekirkwood
Copy link
Contributor

@t3chguy given our work on this topic (header and tooltips), has this work been done ?

@t3chguy
Copy link
Member Author

t3chguy commented Jul 19, 2024

This was done by Florian going and updating all existing tooltips to use Compound.

@t3chguy t3chguy closed this as completed Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Tooltips Anything related to tooltips O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Regression Z-Compound
Projects
None yet
Development

No branches or pull requests

8 participants