Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invite dialog pills have poor styling #26098

Closed
turt2live opened this issue Sep 1, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11722
Closed

Invite dialog pills have poor styling #26098

turt2live opened this issue Sep 1, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#11722
Labels
A-User-Search The start DM or invite to room dialogs (things dealing with `/user_directory/search`) O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Regression

Comments

@turt2live
Copy link
Member

Steps to reproduce

  1. In a group chat, click the "Invite to this room" button
  2. Search for or add a user to the invite list

Outcome

What did you expect?

Legible text, aligned elements.

What happened instead?

image

The user's pill is extremely low contrast, and the x next to the pill is not vertically centered with the pill.

Operating system

Windows 11

Application version

Element Nightly version: 0.0.1-nightly.2023090101 Olm version: 3.2.14

How did you install the app?

The Internet

Homeserver

t2l.io

Will you send logs?

No
@dbkr dbkr added S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience A-User-Search The start DM or invite to room dialogs (things dealing with `/user_directory/search`) labels Sep 7, 2023
@richvdh richvdh changed the title Invite dialog pills have regressed Invite dialog pills have poor styling Sep 7, 2023
@gabrc52
Copy link

gabrc52 commented Oct 7, 2023 •
edited
Loading

Can reproduce, this seems like a relatively new regression

This is how it looked like before:

image

This is how it looks like now:

image

Could we add the "A11y" tag to it?

image

This was referenced Oct 8, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-User-Search The start DM or invite to room dialogs (things dealing with `/user_directory/search`) O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Regression
Projects
None yet
Milestone
No milestone
4 participants
@dbkr @turt2live @t3chguy @gabrc52