Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message shieds are not aligned to text #26142

Closed
weeman1337 opened this issue Sep 8, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11703
Closed

Message shieds are not aligned to text #26142

weeman1337 opened this issue Sep 8, 2023 · 2 comments · Fixed by matrix-org/matrix-react-sdk#11703
Labels
good first issue Good for newcomers Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect

Comments

@weeman1337
Copy link
Contributor

weeman1337 commented Sep 8, 2023

Steps to reproduce

  1. Try to get a message shield, e.g. send a message from an unverified device
  2. Look at message shields

Only affects

  • bubble layout
  • modern layout without „compact“ flag

Outcome

What did you expect?

Aligned to text

What happened instead?

Not aligned. A little too far up / down

image

image

Replies

image

compared to the modern, „compact“ layout

image

Operating system

Ubuntu 22.04.3 LTS

Browser information

Firefox 117.0

URL for webapp

https://develop.element.io/

Application version

Element version: 6dc6c80-react-0ee2eac0e592-js-f963ca55627e Olm version: 3.2.14

Homeserver

No response

Will you send logs?

No

@weeman1337 weeman1337 added T-Defect S-Tolerable Low/no impact on users O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience Help Wanted Extra attention is needed good first issue Good for newcomers labels Sep 8, 2023
@bhargavagonugunta
Copy link

hi sir @weeman1337 i want to solve this issue please assign me sir

@weeman1337
Copy link
Contributor Author

hi sir @weeman1337 i want to solve this issue please assign me sir

Thank you for your interest in this issue. We will normally not assign the issue to an external contributor until they have provided at least a draft PR which is taking the right direction. For further details, see our guidance on assigning issues.

If you have any technical questions about this issue, you can ask for help in #element-dev:matrix.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Help Wanted Extra attention is needed O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants