Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Element-R: support for QR code login #26350

Closed
richvdh opened this issue Oct 10, 2023 · 5 comments
Closed

Element-R: support for QR code login #26350

richvdh opened this issue Oct 10, 2023 · 5 comments
Assignees
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement Z-Element-R-Blocker A blocker for enabling Element R by default Z-Labs

Comments

@richvdh
Copy link
Member

richvdh commented Oct 10, 2023

Element web currently has some support for the experimental QR code login (MSC3906), but apparently it doesn't work with rust crypto.

Not really sure what needs doing to fix this.

@richvdh richvdh added A-Element-R Issues affecting the port of Element's crypto layer to Rust T-Enhancement labels Oct 10, 2023
@weeman1337 weeman1337 added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Uncommon Most users are unlikely to come across this or unexpected workflow Z-Labs labels Oct 11, 2023
@BillCarsonFr BillCarsonFr added the Z-Element-R-Blocker A blocker for enabling Element R by default label Nov 8, 2023
@richvdh
Copy link
Member Author

richvdh commented Nov 28, 2023

The scope of this is to support @hughns in updating "legacy" QR code login (ie MSC3906) to work with Rust crypto. (There are plans to rework QR code login, but they are out of scope here.

@hughns has done most of the necessary work in matrix-org/matrix-js-sdk#3761.

@hughns
Copy link
Member

hughns commented Jan 12, 2024

As requested by @pmaier1, my understanding of the state of this is that there are two parts needed:

@hughns hughns removed their assignment Jan 12, 2024
@hughns
Copy link
Member

hughns commented Jan 12, 2024

Sorry, I remembered one more thing that doesn't work with Rust crypto enabled:

After the QR sign in is completed the list of devices shown in the Sessions tab does not automatically update to show the new device.

I think either:

  • the list of devices in Session manager should update automatically like it does with non-Rust crypto
  • the QR flow should trigger the list of devices to be refreshed

@pmaier1
Copy link

pmaier1 commented Jan 12, 2024

After the QR sign in is completed the list of devices shown in the Sessions tab does not automatically update to show the new device.

I think you've hit this bug which we've not prioritised so far #26263. Should be independent of QR code login, if I'm not mistaken.

@BillCarsonFr
Copy link
Member

Closed as matrix-org/matrix-js-sdk#3761 is merged , and matrix-org/matrix-react-sdk#12139 is closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement Z-Element-R-Blocker A blocker for enabling Element R by default Z-Labs
Projects
None yet
Development

No branches or pull requests

5 participants