Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Disabled for Element R] Flaky Cypress test Read receipts > Paging up > Paging up to find old threads that were never read keeps the room unread #26539

Closed
andybalaam opened this issue Nov 9, 2023 · 4 comments
Closed

[Disabled for Element R] Flaky Cypress test Read receipts > Paging up > Paging up to find old threads that were never read keeps the room unread #26539

andybalaam opened this issue Nov 9, 2023 · 4 comments
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust A-Testing Testing, code coverage, etc. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist Z-Flaky-Test A test is raising false alarms Z-Labs

Comments

@andybalaam
Copy link
Member

For example: https://github.com/matrix-org/matrix-js-sdk/actions/runs/6814052545/job/18530029014#step:8:594

read-receipts/high-level.spec.ts                                               (
...
  6 passing (20m)
  30 pending
  1 failing

  1) Read receipts
       Paging up
         Paging up to find old threads that were never read keeps the room unread:

      Timed out retrying after 10000ms
      + expected - actual

      -'8'
      +'6'
@andybalaam andybalaam added Z-Flaky-Test A test is raising false alarms A-Element-R Issues affecting the port of Element's crypto layer to Rust S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Nov 9, 2023
@github-actions github-actions bot added the Z-Labs label Nov 9, 2023
@andybalaam
Copy link
Member Author

I just ran this locally 10 times (with CYPRESS_RUST_CRYPTO=1) and it passed every time. So either it was a one-off, or it only happens on CI. (Or the failure was caused by my unmerged change, which I will test next...)

@andybalaam
Copy link
Member Author

Nope, seems to work with that change, so maybe this was a one-off, or maybe it only happens in CI.

@Johennes Johennes added the A-Testing Testing, code coverage, etc. label Nov 10, 2023
@andybalaam
Copy link
Member Author

Second strike here, disabling: https://github.com/matrix-org/matrix-js-sdk/actions/runs/6822634889/job/18555022939

@andybalaam andybalaam mentioned this issue Nov 10, 2023
Merged
@andybalaam andybalaam changed the title Flaky Cypress test (Element R) Read receipts > Paging up > Paging up to find old threads that were never read keeps the room unread [Disabled for Element R] Flaky Cypress test Read receipts > Paging up > Paging up to find old threads that were never read keeps the room unread Nov 10, 2023
@florianduros
Copy link
Member

Fixed by matrix-org/matrix-react-sdk#12017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust A-Testing Testing, code coverage, etc. O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist Z-Flaky-Test A test is raising false alarms Z-Labs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andybalaam @Johennes @florianduros