No spell check on the electron app version

[BenfLewis0]

Noticed this when I typed 'doesnt' which always highlights with a red line until you add the apostrophe. Once noticed, I was typing rubbish to test and make sure it wasn't a one off etc but nothing was highlighting.

[dbkr]

This is due to electron/electron#3189

[onePinger]

Spell check is broke in windows also. Any timeline for resolving it?

[ara4n]

this is effectively an electron issue - see also electron/electron#3211.

we may be able to work around it with electron-spellchecker or similar but this is a medium priority bug.

[MTRNord]

Well I think thats what needed: https://github.com/electron/electron/blob/master/docs/api/web-frame.md#webframesetspellcheckproviderlanguage-autocorrectword-provider (Basicly what @ara4n said)

Or this works https://github.com/electron-userland/electron-spellchecker (Seems to be a solution build around electron-spellchecker)

PS: Not tested by me yet

[MTRNord]

/me is now working it. As electron-spellchecker is a native module needed to be loaded inside reactjs but build against electron I need first to figure out webpack magic.

[xenithorb]

RocketChat Electron has a working spellcheck implementation on Linux, see: RocketChat/Rocket.Chat.Electron#266

[MTRNord]

@xenithorb I am still waiting for atom/node-spellchecker#72 My dev env is win 10 and I am affected by this bug. And coding such feature without testing is impossible. :() It would currently only work on Linux as you said. I know that many users use Linux with Riot but as said my Env is Windows :/

[MTRNord]

Also the Code itself is mostly done except for minor styling changes and remerging develop into it.

[anmol26s]

Can someone implement it on Linux,please?

[aaronraimist]

@ara4n What is the legality on including GPL v3 code in Riot? Standard Notes was able to implement spellcheck in their electron app with this commit: standardnotes/desktop@647c65d. Most of the code is GPL v3 licensed from here: https://github.com/signalapp/Signal-Desktop/blob/development/js/spell_check.js

[MTRNord]

PS I know I have a open PR but feel free to make a better PR if you want to.

Also I still search someone to test my PR and if it works on linux!! I might add the suggestions by @aaronraimist if @ara4n gives a green light on the license. (Linux testing is needed as my current spellcheck code does NOT support windows newer than XP according to an upstream issue)

[GriffGreen]

Would love to see this keep moving... my typign sux

[t3chguy]

Added bounty

[anoadragon453]

Signal has it working: https://github.com/signalapp/Signal-Desktop/blob/bffa910c64353f1b8e22c7f9a49aada65479c5ed/js/spell_check.js

[MTRNord]

Closed my PR because of lack of time to maintain. Feel free to make a new PR

[MTRNord]

@lampholder the "in progress" label should propably get removed because of this

[GriffGreen]

I am putting up a gitcoin bounty for 0.5 eth... I hope this helps... When it gets merged the bounty will get paid out

[GriffGreen]

so now there are at least 2 bounties on it :-D

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

This issue now has a funding of 0.5 ETH (106.94 USD @ $213.89/ETH) attached to it as part of the Giveth fund.

• If you would like to work on this issue you can 'start work' on the Gitcoin Issue Details page.
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $53,355.90 more funded OSS Work available on the Gitcoin Issue Explorer

[thecyberd3m0n]

I'm working on it. I've assigned myself using Gitcoin.

[thecyberd3m0n]

I'm at the middle of the task (imported and runned spell-checks on right-click), but I've got concern about dictionaries. I'm able to detect language using my Ubuntu 18.04 complaint KDE Neon, but by default user would not have the dictionary or we should bundle them, or somehow download from kind of dictionaries repository. In Rocket.Chat they've bundled 3 dictionaries (English, Spanisz and Portugal), so for example Polish or Russian are not supported at all.

Any additional ideas and feedback (how you want to access dictionaries and various languages) would be very helpful, by now i'll implement it like Rocket.Chat did.

UPDATE: https://github.com/LibreOffice/dictionaries - more dictionaries

UPDATE2:
Linux: works, builds but only for Linux
Windows: Python 2.x needs to be installed. Not builds with Node v10.16.0
Mac: Not tried yet

[thecyberd3m0n]

#10275

[gitcoinbot]

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

---

Work for 0.5 ETH (147.44 USD @ $294.88/ETH) has been submitted by:

1. @thecyberd3m0n

@GriffGreen please take a look at the submitted work:

• PR by @thecyberd3m0n

---

• Learn more on the Gitcoin Issue Details page
• Want to chip in? Add your own contribution here.
• Questions? Checkout Gitcoin Help or the Gitcoin Slack
• $131,238.70 more funded OSS Work available on the Gitcoin Issue Explorer

[GriffGreen]

oh nice!!! Thank you Soooooooooo much @thecyberd3m0n!!! Thank you for finally taking this on! I have a Mac, so hopefully the mac version works! If so I'll release the bounty :-D

[thecyberd3m0n]

It should, but no guarantee for now. I don't have test environment for Mac yet :(

[thecyberd3m0n]

It seems like I failed to get my PR done. You can dismiss it. Sorry

[aaronraimist]

Looks like Electron 8 will let you use the system spellcheck electron/electron#20692

[BloodyIron]

I'm very much interested in having spell checking in the Desktop version of Riot :D

[dandv]

This was resolved in 1.6. Can someone comment on exactly how? What library is used? Any online lookups for unrecognized words?

[turt2live]

element-hq/element-desktop#30 is the PR which adds it - that would be the best place to start. Other than that, #riot-dev:matrix.org might have more details.

[t3chguy]

It uses the electron 8.x spellcheck feature which downloads a spellcheck dictionary and looks up the words locally from there

https://www.electronjs.org/docs/api/web-frame#webframesetspellcheckproviderlanguage-provider

[banjo8675309]

It would be nice to be able to disable spellchecking...