Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retrying unsent edits fails #26778

Closed
ara4n opened this issue Dec 16, 2023 · 1 comment
Closed

Retrying unsent edits fails #26778

ara4n opened this issue Dec 16, 2023 · 1 comment
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust A-Message-Editing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression Z-Labs

Comments

@ara4n
Copy link
Member

ara4n commented Dec 16, 2023

Steps to reproduce

  1. Send a bunch of messages, and edit one of them
  2. Encryption is slow due to ER problems so they all queue up
  3. Eventually something times out and they 'go red' and fail
  4. Hit retry
  5. Message sending fails immediately:
rageshake.ts:77 Error sending event M_UNKNOWN: MatrixError: [400] Can't send relation to unknown event (https://matrix-client.matrix.org/_matrix/client/v3/rooms/!UcgyhoigetVICUfvRw%3Amatrix.org/send/m.room.encrypted/m1702728156543.1)
    at parseErrorResponse (vector://vector/webapp/bundles/eee97dbd860b28d038a2/bundle.js:129586:12)
    at MatrixHttpApi.requestOtherUrl (vector://vector/webapp/bundles/eee97dbd860b28d038a2/bundle.js:129936:13)
    at async MatrixHttpApi.authedRequest (vector://vector/webapp/bundles/eee97dbd860b28d038a2/bundle.js:129777:24)
    at async MatrixScheduler.procFn (vector://vector/webapp/bundles/eee97dbd860b28d038a2/bundle.js:102961:21)

Outcome

What did you expect?

Unsent edits should queue correctly, rather than silently break the retry mechanism. I'm fairly sure this used to work.

Operating system

No response

Application version

Element Nightly version: 2023121601 Crypto version: Rust SDK 0.6.0 (438880a), Vodozemac 0.5.0

How did you install the app?

No response

Homeserver

matrix.org

Will you send logs?

Yes
@ara4n ara4n added the T-Defect label Dec 16, 2023
@ara4n ara4n mentioned this issue Dec 16, 2023
Open
@MidhunSureshR MidhunSureshR added X-Regression S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-Message-Editing O-Occasional Affects or can be seen by some users regularly or most users rarely A-Element-R Issues affecting the port of Element's crypto layer to Rust labels Dec 18, 2023
@BillCarsonFr
Copy link
Member

Same cause of this #26684
edit is sent before original

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Element-R Issues affecting the port of Element's crypto layer to Rust A-Message-Editing O-Occasional Affects or can be seen by some users regularly or most users rarely S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression Z-Labs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ara4n @MidhunSureshR @BillCarsonFr