Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PiP-PersistedElement rendered in front of Pip-buttons (Hiding call hangup and GoTo room buttons) #26805

Closed
toger5 opened this issue Dec 22, 2023 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12094
Assignees
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker

Comments

@toger5
Copy link
Contributor

toger5 commented Dec 22, 2023

For persisted/sticky/always-on-screen widgets (like element call) we use a persistedElement (A dom element outside the #matrixchat element) to render the app itself.

For calls there are two buttons:

  • Go back to room (room the call belongs to).
  • End call

those buttons are renderd as a <aside> and as a child of the #matrixchat element.
With the tree isolation (contain: strict) we use with compound this is not possible:

 - #matrixchat
   ...
   - "buttons for pip view" (end call, to room)
   ...
 - persistedElement
     ...
     - IFrame

The DOM order of persistedElement ABOVE #matrixchat enforces it to also be rendered above hiding the "buttons for pip view" (end call, to room). We need to refactor the PipContainer to create a dom structure that allows the required rendering order: "buttons above widget"

@t3chguy
Copy link
Member

t3chguy commented Jan 3, 2024

Regressed by matrix-org/matrix-react-sdk#12052

@MidhunSureshR MidhunSureshR added S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Regression X-Release-Blocker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants