Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roles and permissions - saving changes should be on button click, not on combo box change #27083

Closed
lszczygielek opened this issue Feb 28, 2024 · 2 comments · Fixed by matrix-org/matrix-react-sdk#12346
Assignees
Labels
A-Power-Levels The permissions that users have in rooms and spaces A-Right-Panel O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@lszczygielek
Copy link

Steps to reproduce

  1. Create space or room.
  2. Go to Setting -> Roles & Permissions
  3. Start changing your role (Privileged User).

Outcome

What did you expect?

I can change the setting to Moderator or custom Power Level (to 10, as an example), but I can change my mind and return to the previous option.

Saving should be on button click, but there is no Save button, but save on the option change.

What happened instead?

The option is saved after the combo box selection. I cannot revert the action, so I lost permission in my space.

Operating system

Windows 10

Browser information

Firefox

URL for webapp

app.element.io

Application version

Element version: 1.11.59

Homeserver

matrix.org

Will you send logs?

No

@dbkr dbkr added X-Needs-Design A-Right-Panel A-Power-Levels The permissions that users have in rooms and spaces S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Feb 28, 2024
@gaelledel
Copy link

Add an Apply button under the specific privilege section

@dbkr
Copy link
Member

dbkr commented Mar 5, 2024

Screenshot 2024-03-05 at 13 10 23

For context, above is the screen where the 'Add privileged users' section has an apply button, but the section above doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Power-Levels The permissions that users have in rooms and spaces A-Right-Panel O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants