Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backup import | When keys can be decrypted but not imported (malformed), web doesn't properly report failures #27235

Open
BillCarsonFr opened this issue Mar 25, 2024 · 1 comment · May be fixed by matrix-org/matrix-js-sdk#4131
Open

Backup import | When keys can be decrypted but not imported (malformed), web doesn't properly report failures #27235

BillCarsonFr opened this issue Mar 25, 2024 · 1 comment · May be fixed by matrix-org/matrix-js-sdk#4131
Assignees
@BillCarsonFr
Labels
A-E2EE A-E2EE-Key-Backup A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Team: Crypto

Comments

@BillCarsonFr
Copy link
Member

Some keys in backup can be invalid/malformed, e.g. missing sender_clained_keys.
When importing the keys, the final report will not show that some keys failed to be imported.

Actual:
image

But in the logs we can see that only 5 out of the 8 keys have been imported:

INFO matrix_sdk_crypto::store: Successfully imported room keys
    total_count=5 imported_count=5 room_keys={"!EmsODKgTIPJPzqAppz:localhost": {"mBIlHJS672lt4KiDDLXXA5FF9ut2bSeIZhCeW+daqw4": {"p0BaulY0KHB1bw5+4yE9HU36xM5jesfgHGfOg1j1hIA", "zDCkd9UFazLZ+4ePUYUZF2SH+5f7QJaKAxL/oOKjFKw"}, "u7TR37MWbZyCsG631MPJROSKWL9wP8d0M6cbDjUeT1Y": {"F9jW7QUDakTgmvDzQGS6b1JooybZBOO5h7Gtf6tdDZQ"}}, "!pveNGnGiEBWCoTwyBz:localhost": {"mBIlHJS672lt4KiDDLXXA5FF9ut2bSeIZhCeW+daqw4": {"YrhdHY46fmW5vf7bjjaymRvHIHPYN+Ev0yen6R5R4p0"}, "u7TR37MWbZyCsG631MPJROSKWL9wP8d0M6cbDjUeT1Y": {"SeKUKJe0jhLl/n9DZ2sjojigeluXCZUUhiktAyy7WOU"}}}
@BillCarsonFr BillCarsonFr linked a pull request Mar 25, 2024 that will close this issue
Open
4 tasks
@BillCarsonFr BillCarsonFr self-assigned this Mar 25, 2024
@florianduros florianduros added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround O-Uncommon Most users are unlikely to come across this or unexpected workflow Team: Crypto A-Element-R Issues affecting the port of Element's crypto layer to Rust labels Mar 25, 2024
@richvdh richvdh added the A-E2EE label Apr 3, 2024
@richvdh
Copy link
Member

richvdh commented Apr 3, 2024

Also: we should probably distinguish between new keys that were imported/updated, and keys that we already had.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BillCarsonFr BillCarsonFr

Labels
A-E2EE A-E2EE-Key-Backup A-Element-R Issues affecting the port of Element's crypto layer to Rust O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect Team: Crypto
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix progress reporting for key import matrix-org/matrix-js-sdk
3 participants
@richvdh @florianduros @BillCarsonFr