Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should remove allow-downloads-without-user-activation for iframes #27587

Closed
MarcWadai opened this issue Jun 17, 2024 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12633
Closed

Should remove allow-downloads-without-user-activation for iframes #27587

MarcWadai opened this issue Jun 17, 2024 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12633
Assignees
@t3chguy
Labels
A-File-Download O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@MarcWadai
Copy link

Steps to reproduce

  1. Where are you starting? What can you see?
    An error from a user appearedon the console while downloading a file

image

linked to this issue tchapgouv/tchap-web-v4#1029

  1. What do you click?
    Download a file

  2. More steps…

Outcome

What did you expect?

No error to appear on the console

What happened instead?

The error above appeared. On element code, the directive allow-downloads-without-user-activation on the iframe seems to be used next to allow-downloads. According to the documentation mdn/content#33409, it seems that this directive has been removed and shouldn't be used.

Operating system

Mac OS

Browser information

Chrome 126

URL for webapp

No response

Application version

1.11.67

Homeserver

No response

Will you send logs?

Yes
@t3chguy
Copy link
Member

t3chguy commented Jun 17, 2024

If it has been abandoned then I wonder why w3c/webappsec-permissions-policy#289 isn't closed

@dosubot dosubot bot added A-File-Download S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jun 17, 2024
@t3chguy t3chguy self-assigned this Jun 18, 2024
@t3chguy t3chguy mentioned this issue Jun 18, 2024
Merged
@MidhunSureshR MidhunSureshR added the O-Occasional Affects or can be seen by some users regularly or most users rarely label Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-File-Download O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove outdated iframe sandbox attribute matrix-org/matrix-react-sdk
3 participants
@t3chguy @MidhunSureshR @MarcWadai