Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blinking shields #27591

Closed
ara4n opened this issue Jun 17, 2024 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12632
Closed

Blinking shields #27591

ara4n opened this issue Jun 17, 2024 · 1 comment · Fixed by matrix-org/matrix-react-sdk#12632
Assignees
@t3chguy
Labels
A-E2EE S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker

Comments

@ara4n
Copy link
Member

ara4n commented Jun 17, 2024

Steps to reproduce

  1. Write a msg in an encrypted room
  2. See the green shield flicker like this:
flickering.shield.mov

Outcome

What did you expect?

Shield should rapidly show the correct state on switching to a room and not flicker all the time.

What happened instead?

Unsettling flickering making it feel like encryption might be flakey.

Operating system

No response

Application version

2024061701

How did you install the app?

No response

Homeserver

No response

Will you send logs?

No
@ara4n ara4n added the T-Defect label Jun 17, 2024
@dosubot dosubot bot added A-E2EE S-Minor Impairs non-critical functionality or suitable workarounds exist labels Jun 17, 2024
@t3chguy
Copy link
Member

t3chguy commented Jun 18, 2024

Regressed by matrix-org/matrix-react-sdk#12606

@t3chguy t3chguy added X-Regression X-Upcoming-Release-Blocker This does not affect the current release cycle but will affect the next one labels Jun 18, 2024
@t3chguy t3chguy self-assigned this Jun 18, 2024
@t3chguy t3chguy mentioned this issue Jun 18, 2024
Merged
@github-actions github-actions bot added X-Release-Blocker and removed X-Upcoming-Release-Blocker This does not affect the current release cycle but will affect the next one labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@t3chguy t3chguy

Labels
A-E2EE S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove stray setState which caused encryption state shields to flicker matrix-org/matrix-react-sdk
2 participants
@ara4n @t3chguy