Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Members only (since the point in time of selecting this option)" makes no sense for encrypted rooms #27977

Open
2 tasks
Tracked by #2516
richvdh opened this issue Aug 29, 2024 · 0 comments
Open
2 tasks
Tracked by #2516

"Members only (since the point in time of selecting this option)" makes no sense for encrypted rooms #27977

richvdh opened this issue Aug 29, 2024 · 0 comments
Labels
A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@richvdh
Copy link
Member

richvdh commented Aug 29, 2024

Since history sharing is not implemented for encrypted rooms (#26867), the history visibility setting "Members only (since the point in time of selecting this option)" is essentially a lie.

  • We should hide that option for encrypted rooms
  • We should also consider using history_visibility: invite when creating a new room with encryption enabled
@dosubot dosubot bot added A-Room-Settings S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect labels Aug 29, 2024
@dbkr dbkr added the O-Occasional Affects or can be seen by some users regularly or most users rarely label Aug 29, 2024
@richvdh richvdh mentioned this issue Aug 29, 2024
Open
2 tasks
@Delphgateau Delphgateau mentioned this issue Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Room-Settings O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dbkr @richvdh