Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invite UI has become incredibly slow #3204

Closed
ara4n opened this issue Feb 10, 2017 · 3 comments
Closed

invite UI has become incredibly slow #3204

ara4n opened this issue Feb 10, 2017 · 3 comments
Assignees
@lukebarnard1
Labels
A-Performance P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@ara4n
Copy link
Member

ara4n commented Feb 10, 2017

the text-search is pausing for ~5s for me as i try to invite people; seems like we're missing some ratelimiting
@tessgadwa tessgadwa mentioned this issue Feb 10, 2017
Closed
71 tasks
@ara4n ara4n added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround P1 A-Performance labels Feb 18, 2017
@ara4n
Copy link
Member Author

ara4n commented Feb 21, 2017

this is in ChatInviteDialog

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Mar 9, 2017 •
edited
Loading

@ara4n it would be good to know if fuse has made this worse/better (I'm guessing worse, given that the prev impl was using indexOf)

@lukebarnard1
Copy link
Contributor

Closing this because things seem fast (at least on my account). We can reopen if performance with using Flux to search appears slow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukebarnard1 lukebarnard1

Labels
A-Performance P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ara4n @lukebarnard1