Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to unread displays in some improper circumstances #4180

Open
Autre31415 opened this issue Jun 3, 2017 · 12 comments
Open

Jump to unread displays in some improper circumstances #4180

Autre31415 opened this issue Jun 3, 2017 · 12 comments
Labels
A-Read-Marker Green line showing how far _you_ have read P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect

Comments

@Autre31415
Copy link

Autre31415 commented Jun 3, 2017

I see this message in chats pop up every so often even though i've seen all the messages already

unread message

OS: macOS Sierra
riot-web: 0.10.1

@Autre31415 Autre31415 changed the title Jump to unread displays in some impropor circumstances Jump to unread displays in some improper circumstances Jun 3, 2017
@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Jun 6, 2017

@Autre31415 does the bar appear even when you've clicked the "X"?

This feels related to https://github.com/vector-im/riot-web/issues/4134

@Autre31415
Copy link
Author

The 'X' does get rid of it.

@lukebarnard1
Copy link
Contributor

OK, then it sounds like you're expecting it to disappear when you scroll down but it doesn't because you need to scroll quite slowly. If you click the "Jump to.." and then scroll down quickly, would you expect the banner to disappear?

@Autre31415
Copy link
Author

This isn't an issue that I've witnessed in prior versions of Riot.

The jump to unread indicator has a tendency to pop up while I'm actively engaged in a conversation, and jumping to the first unread message will take it all the way back to when the conversation started even though I've been active in the conversation the entire time and no notifications have spawned.

@lukebarnard1
Copy link
Contributor

Right, so that sounds like a bug where the app's/view's read marker is not up-to-date with the server's.

@lampholder lampholder added S-Minor Impairs non-critical functionality or suitable workarounds exist P1 labels Jun 7, 2017
@4nd3r
Copy link
Contributor

4nd3r commented Jun 27, 2017

Ander: ugh, when will the "Jump to first unread" will be fixed? :<
Dave: we just did a bunch of fixes, if it's not working please file a bug
Ander: just did? i'm using 0.11.4. or are those fixes in develop?
Dave: they're in 0.11.4

so, with 0.11.4 it's still on. this annoying pop up comes up quite often. clicking on it takes me back more than a day or days, even if the last message in room was sent by me few minutes ago.

@lukebarnard1
Copy link
Contributor

@4nd3r you can get rid of it by clicking "X".

clicking on it takes me back more than a day or days

This is expected behaviour

even if the last message in room was sent by me few minutes ago

And so is this. If you are just finding the pop up annoying or unintuitive, see https://github.com/vector-im/riot-web/issues/4134

@pravi
Copy link
Contributor

pravi commented Aug 16, 2017

@lukebarnard1 I think I found the root cause. When more than 3 collapsed activities are present, you need to expand at least one of them for the read marker to consider it read. So even if you scroll down slowly, the read marker does not get updated and takes you far back to the first unread message every time since that cannot be marked as read unless you expand the collapsed messages. This is an issue in bridged rooms because IRC or Telegram bridges generate a lot of join/left or profile pic changed messages.

@wlinna
Copy link

wlinna commented Nov 6, 2017

I can almost never rely on "Jump to first unread message.". I have a simple 1-on-1 chat, where nobody leaves, changes names etc. Sometimes it takes me a week back. Half of the time it takes me back to my own message (it underlines my own message). It also takes me back to redacted events, closed a call events and so on.

@lukebarnard1
Copy link
Contributor

@TripleSnail, none of that is unexpected behaviour afaik - in reality we track the first unread event.

If you send a message into the room and then leave your client reading messages into the room (without focusing on the window) your read marker will still be underneath the message that you sent - it was the last message you read.

@wlinna
Copy link

wlinna commented Nov 6, 2017

I had always understood, that it underlined the message that I had not read. Well, I guess everything makes more sense now.

@BloodyIron
Copy link

I see this message ALL THE TIME when I'm already current in a channel. Can we please get this back into the pipeline in some way?

@afranke afranke added the A-Read-Marker Green line showing how far _you_ have read label Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Read-Marker Green line showing how far _you_ have read P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect
Projects
None yet
Development

No branches or pull requests

8 participants