Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Click-to-ping someone with an emoji in their name doesn't create a pill #4581

Closed
turt2live opened this issue Jul 14, 2017 · 5 comments
Closed
Labels
P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@turt2live
Copy link
Member

Description

image

Blurred for privacy where possible. Red emphasis is to highlight the issue.

Steps to reproduce

  • Have an emoji in your name
  • Click your name to ping yourself

Log: not sent

Version information

  • Platform: web (in-browser)
  • Browser: Chrome 58
  • OS: Windows 10
  • URL: riot.im/develop
@lampholder
Copy link
Member

There's something about the ☎️ emoji that is being handled differently to the 🕹 emoji (that I randomly had as part of my display name before).

The RTE is certainly capable of displaying ☎️, as evidenced if you type ☎️, but it's not rendering in the editor when pasted in. It does appear in the timeline though.

To reproduce, copy the below, paste it into the new RTE, note the absense of the telephone in the editor, press send, note the presence of the telephone in the timeline.

Why can I see the joystick (🕹) but not the classy old-skool telephone (☎️)?

@lampholder lampholder added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround P2 type:rte labels Jul 17, 2017
@lukebarnard1
Copy link
Contributor

This is probably because emojis have entities attached to them to make them immutable.

@turt2live
Copy link
Member Author

They now show up, however they are not pilled

@turt2live turt2live changed the title Click-to-ping someone with an emoji in their name doesn't show the emoji in the field. Click-to-ping someone with an emoji in their name doesn't create a pil Nov 28, 2017
@turt2live turt2live changed the title Click-to-ping someone with an emoji in their name doesn't create a pil Click-to-ping someone with an emoji in their name doesn't create a pill Nov 28, 2017
@ara4n
Copy link
Member

ara4n commented Jul 16, 2018

i think this has been fixed in matrix-org/matrix-react-sdk#1890 if someone can check (i can't find a good one to test against)

@ara4n ara4n closed this as completed Jul 16, 2018
@t3chguy
Copy link
Member

t3chguy commented Jul 16, 2018

Yup!
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

5 participants