We seem to have broken pill highlights on search results

[ara4n]

When you search for something you're meant to see a pill around the matching term in the search results. It seems to have gone awol.

[lampholder]

I can't reproduce this on /develop on Chrome on Ubuntu or Mac OSX

@ara4n are you able to share the search term or the matching text to help diagnose/triage?

[grahamperrin]

I get a pill on the search term but not on the authors:

[turt2live]

This seems a bit temperamental about when to pill or not:

seems to work fine for code blocks:

(keyword was draft in #riot-dev btw)

[yannicka]

On Riot Desktop 1.6.0, some results are not highlighted (search for "call" on "#riot-web:matrix.org"):

[t3chguy]

This could well be a Synapse bug as the Synapse FTS is what tells us what to highlight in each message

[poljar]

Isn't that a search across all rooms? If so results from encrypted search results won't have the highlight.

[t3chguy]

Shouldn't the seshat-backed search have the same API as the Matrix server backed one and thus do that too?

[t3chguy]

also looking at the gif, that one is This room only

[poljar]

Right, I think I forgot how the highlights work. Seems to be Seshat unrelated indeed.

[kittykat]

Pills seems to sometimes be working reliably and sometimes not be working reliably:

search-pills.mp4

[t3chguy]

Seems to work far more reliably now