Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back the hs_url parameter and document it #5469

Open
uhoreg opened this issue Oct 29, 2017 · 17 comments · May be fixed by #17824
Open

Bring back the hs_url parameter and document it #5469

uhoreg opened this issue Oct 29, 2017 · 17 comments · May be fixed by #17824
Labels
A-Config A-Login A-Registration O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement

Comments

@uhoreg
Copy link
Member

uhoreg commented Oct 29, 2017

which was added in matrix-org/matrix-react-sdk#716 but doesn't seem to be documented anywhere

@uhoreg
Copy link
Member Author

uhoreg commented Oct 29, 2017

to clarify, this is about being able to do things like https://riot.im/#/register?hs_url=matrix.whatever, and not about the config.json parameters

@dagwieers
Copy link

Why not contribute a PR with exactly what you expect ?

@aaronraimist
Copy link
Collaborator

Is this option broken in 0.17.9?

@t3chguy
Copy link
Member

t3chguy commented Mar 18, 2020

Yes #9908

@t3chguy t3chguy closed this as completed Mar 18, 2020
@aaronraimist
Copy link
Collaborator

@t3chguy this one had more thumbs so maybe this should turn into the fix hs_url issue

@t3chguy
Copy link
Member

t3chguy commented Mar 19, 2020

Sure.

@t3chguy t3chguy reopened this Mar 19, 2020
@t3chguy t3chguy changed the title document the hs_url parameter Bring back the hs_url parameter and document it Mar 19, 2020
@t3chguy
Copy link
Member

t3chguy commented Mar 19, 2020

Taking over #9908

@okias
Copy link

okias commented Jul 1, 2020

Would be really great to have it fixed.

@melroy89
Copy link

melroy89 commented Jan 12, 2021

I can't agree more, especially if matrix want to become more decentralized and more federated.

Example link (it still doesn't work):
https://app.element.io/?hs_url=https://matrix.melroy.org#/login

@bwindels
Copy link
Contributor

I wonder if phishing is a concern here as well,
getting people to try and log in on a malicious homeserver

@aaronraimist aaronraimist linked a pull request Jun 29, 2021 that will close this issue
@benjaoming
Copy link

Definitely voting for this, no worries about phishing, this is a big show stopper for federation, as it makes users sign up to matrix.org and creates a lot of manually supported mess.

It also leads to this wrong behavior:

  1. Create an invite link for a Room
  2. Follow the link in private browser session
  3. Click "Sign Up"
  4. Observe that we went from looking at the home server in step 2 to signing up on "matrix.org" in step 3.

The behavior needs to be implemented so it goes into this flow, too?

@binarymaster
Copy link

Out of curiosity I have tried to change the link to this:

https://app.element.io/#/login&hs_url=https://matrix.melroy.org (notice the hs part goes after the hash, not part of URL query)

And for some reason it makes Element hang on loading, no matter what homeserver is specified.

@timmc
Copy link

timmc commented Nov 27, 2021

Yeah, I've found that the lack of this is a serious usability problem for the people I've invited to chat on my server. After they register they go to element.io and then they have to do a complicated little dance and pay attention to terminology that's new to them ("homeserver") in order to sign in properly.

@PxBCPG
Copy link

PxBCPG commented Jan 17, 2022

how is it going?

@t3chguy t3chguy added A-Registration A-Login T-Enhancement A-Config O-Uncommon Most users are unlikely to come across this or unexpected workflow and removed T-Defect P1 A-Documentation labels Oct 17, 2022
@Babalion
Copy link

Hey guys,

in my opinion it shouldn't be that difficult to plug in a string from an url-parameter...
It would be nice for the initial user experience to have this feature working!

Maybe I am able to create a pull request but i am completely new to the element development.
Where exactly is this thing handled? Which files does one have to change?

Thanks!

@benjaoming
Copy link

@Babalion that sounds great, but a suggestion is already up in a PR, you could help out there? #17824

@alexander-potemkin
Copy link

It's a thing working on iOS, guess it makes perfect sense from the user perspective to have things working unified across the platforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Config A-Login A-Registration O-Uncommon Most users are unlikely to come across this or unexpected workflow T-Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.