Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Now Chrome/FF/Safari all support WASM, we should probably use it for Olm #5591

Closed
ara4n opened this issue Nov 14, 2017 · 8 comments
Closed

Now Chrome/FF/Safari all support WASM, we should probably use it for Olm #5591

ara4n opened this issue Nov 14, 2017 · 8 comments
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Task Tasks for the team like planning

Comments

@ara4n
Copy link
Member

ara4n commented Nov 14, 2017

I think this is just as easy as shoving a -s WASM=1 into the emscripten runes when building olm for matrix-js-sdk? See https://github.com/kripken/emscripten/wiki/WebAssembly
@lampholder
Copy link
Member

Does this pin us to more modern versions of browsers, or does it fall back to the non webassembly version if the browser doesn't include support?

@lampholder lampholder added T-Task Tasks for the team like planning S-Major Severely degrades major functionality or product features, with no satisfactory workaround P1 labels Nov 22, 2017
@uhoreg
Copy link
Member

uhoreg commented Jan 6, 2018

see also element-hq/element-desktop#888

@fuzzy76
Copy link

fuzzy76 commented Mar 26, 2018

According to https://caniuse.com/#feat=wasm that would exclude ~26% of browsers (~18% if you filter by desktop users).

@uhoreg
Copy link
Member

uhoreg commented Jun 9, 2018

This may not be as easy as just setting -s WASM=1, as per matrix-org/olm#12

@dbkr
Copy link
Member

dbkr commented Sep 26, 2018

#7385 does this!

@dbkr
Copy link
Member

dbkr commented Oct 3, 2018

The notable exception in that list is TorBrowser which explicitly disables WASM

@ara4n
Copy link
Member Author

ara4n commented Jan 8, 2019

@dbkr can we close this then? :)

@turt2live
Copy link
Member

I'm voting yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Task Tasks for the team like planning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@fuzzy76 @dbkr @uhoreg @turt2live @ara4n @lampholder