Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communities aren't guest/new user accessible from links #5650

Closed
Mikaela opened this issue Nov 19, 2017 · 15 comments
Closed

Communities aren't guest/new user accessible from links #5650

Mikaela opened this issue Nov 19, 2017 · 15 comments
Labels
A-Spaces Spaces, groups, communities P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect

Comments

@Mikaela
Copy link
Contributor

Mikaela commented Nov 19, 2017

Description

Going to https://riot.im/app/#/group/+matrix:matrix.org without logging in gives a prompt for username which leads to two options:

  1. press X and Riot will load forever.
  2. enter username and be introduced to Riot as a new user without ever seeing https://riot.im/app/#/group/+matrix:matrix.org without entering the page again, and who does that?

Steps to reproduce

I expected to see +matrix:matrix.org, but instead I see Riot bot.

screenshot from 2017-11-19 11-07-35
screenshot from 2017-11-19 11-07-55
screenshot from 2017-11-19 11-08-46

First there is selecting username, then eternal loading after clicking X to close it and after refreshing the page and setting username, I am asked for username again and thrown into some room that has nothing to do with +matrix:matrix.org.

Being able to link guests to community pages would be important for those communities which include multiple rooms (23) and cannot go telling people to join #bridge_#channel:example.net and saying change CHANNEL to ANOTHERCHANNEL 22 times and I have understood that Riot doesn't even support multiple instances within the same browser.

Version information

  • Platform: web (in-browser)

For the web app:

  • Browser: Firefox 58.0b4
  • OS: Arch Linux
  • URL: riot.im/app

Firefox 58.0b4, Arch Linux, https://riot.im/app

@lukebarnard1
Copy link
Contributor

Being able to link guests to community pages would be important for those communities which include multiple rooms

Absolutely, and the intention with guests is to allow them to access public groups and their public memberships and room associations. The server currently disallows guest access.

And of course this doesn't justify the flow being buggy.

  1. Sounds like we forgot to think about what happens when someone cancels the username dialog without having been in the app already (prior to navigating to it).
  2. Sounds like the intention to view the group after sign-in happens at a point before the user is considered non-guest.

@lampholder lampholder added T-Defect ILAG S-Minor Impairs non-critical functionality or suitable workarounds exist P2 A-Spaces Spaces, groups, communities labels Nov 23, 2017
@ara4n ara4n added S-Major Severely degrades major functionality or product features, with no satisfactory workaround P1 and removed S-Minor Impairs non-critical functionality or suitable workarounds exist P2 labels Nov 27, 2017
@ara4n
Copy link
Member

ara4n commented Nov 27, 2017

the fact we can't use communities for onboarding is a huge problem, and i've reprioritised to reflect...

@ara4n
Copy link
Member

ara4n commented Nov 27, 2017

@lukebarnard1 this should take priority over LeftLeftPanel stuff please.

@lukebarnard1
Copy link
Contributor

lukebarnard1 commented Nov 28, 2017

Having just tried the repro steps, I get a different experience where I see +matrix as a registered user, but with a second "To get started, ..." displayed. This supports

Sounds like the intention to view the group after sign-in happens at a point before the user is considered non-guest.

Instead of improving the current flow, let's just make synapse allow guest access of public group info. When the user starts clicking on rooms, they can become a real user and join a room.

The preferable flow is for the guest being unable to "knock", but knocking isn't implemented yet.

@ara4n
Copy link
Member

ara4n commented Nov 28, 2017

sgtm. is this on your radar?

@lukebarnard1
Copy link
Contributor

matrix-org/synapse#2715 is merged and will let guests see groups

@ara4n
Copy link
Member

ara4n commented Dec 3, 2017

@erikjohnston please can we get this on matrix.org tomorrow? more clusters today with folks advertising groups the public can’t join...

@ara4n
Copy link
Member

ara4n commented Apr 12, 2018

so apparently this didn't fix things :(

@lukebarnard1
Copy link
Contributor

Seems fine to me..
screen shot 2018-04-14 at 11 16 15

@t3chguy
Copy link
Member

t3chguy commented Jul 15, 2018

Seems fine to me also

@ara4n
Copy link
Member

ara4n commented Jul 16, 2018

closing at @Mikaela's request

@ara4n ara4n closed this as completed Jul 16, 2018
@vesterinen
Copy link

This is still not working for me when landing onto a community page. It shows me to page and once I try to click to register so I could comment and pushes me first to choose username and then to accept 'terms and conditions'. Then it lands me on the Riot.im landing page. Not to the community page I tried to get to.

@vesterinen
Copy link

This is still not working for me when landing onto a community page. It shows me to page and once I try to click to register so I could comment and pushes me first to choose username and then to accept 'terms and conditions'. Then it lands me on the Riot.im landing page. Not to the community page I tried to get to.

exactly as I reported earlier here #6247 (comment)

@turt2live
Copy link
Member

@vesterinen I've opened #7529 to track one of the issues with the community page. Clicking "Register" on the left isn't going to be possible in the next release because the button has moved to where the composer would be (which is not shown on the community page).

For reference, the page not loading at all is #7204

@vesterinen
Copy link

@vesterinen I've opened #7529 to track one of the issues with the community page. Clicking "Register" on the left isn't going to be possible in the next release because the button has moved to where the composer would be (which is not shown on the community page).

For reference, the page not loading at all is #7204

got it! thanks for the quick reply

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Spaces Spaces, groups, communities P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect
Projects
None yet
Development

No branches or pull requests

7 participants