Clear cache and reload should probably explain what it actually does

[pafcu]

Description

Currently there is no explanation what the "Clear cache and reload" button in user settings actually does. What is stored in the cache? What happens if you clear it? Currently the button is red, which indicates it might be dangerous, but the user has no way of deciding if they want to "take the risk". As per #5724 (comment) it could be made yellow/orange instead, but some explanation of what the button does, and why you should be careful with it, would be nice to have.

Version information

• Platform: web

For the web app:

• Browser: Firefox 57
• OS: Linux
• URL: riot.im/develop

[lampholder]

Ah yes, this adds a nuance to #7539

[anoadragon453]

It really should get its own section. I've also had reports of users hitting "Clear cache and reload" accidentally when they go to hit "Submit debug logs", which is probably not what we want if we want users to catch hard-to-find bugs.

[abhinav-TB]

@aaronraimist I would like to work on this issue could you give some guidance

[aaronraimist]

@abhinav-TB This is where the button is created in code. https://github.com/matrix-org/matrix-react-sdk/blob/4f52afdb3c15b5c46cf8a00f0b971637e1147148/src/components/views/settings/tabs/user/HelpUserSettingsTab.js#L273-L277

You can add a sentence or two explaining what clear cache does right above it. It would look something like https://github.com/matrix-org/matrix-react-sdk/blob/4f52afdb3c15b5c46cf8a00f0b971637e1147148/src/components/views/settings/tabs/user/HelpUserSettingsTab.js#L171-L174

If you need more help feel free to join the #element-dev:matrix.org room.

[tawfiek]

I would like to help with this, can anybody Assign it to me ?!

[SimonBrandner]

@tawfiek, done!

[tawfiek]

I think it's fixed already !!
Do I still need to explain what this btn does ?!

[SimonBrandner]

I think it's fixed already !!

Is it? I don't think I understand...

[tawfiek]

It really should get its own section. I've also had reports of users hitting "Clear cache and reload" accidentally when they go to hit "Submit debug logs", which is probably not what we want if we want users to catch hard-to-find bugs.

compared to this view I think this issue have been solved somewhere

[SimonBrandner]

"Clear cache and reload" button in user settings actually does. What is stored in the cache? What happens if you clear it?

Yeah, but I don't think there is anything about this...

[ptman]

I don't know if this is the right place. Please direct me to a more suitable issue.

Is it possible to detect when the local state ("cache") is in conflict with what the server thinks is true and do a local state rebuild ("clear cache and reload") automatically?

[t3chguy]

Is it possible to detect when the local state ("cache") is in conflict with what the server thinks is true and do a local state rebuild ("clear cache and reload") automatically?

Not without basically having to constantly initial sync (same thing the clear cache & reload does) with the server and comparing, this operation is really expensive on the server and processing that much JSON will likely also slow down your user experience.

[ptman]

@t3chguy Ok, let me rephrase: I'm not looking for a way to make sure the cache is always known to be good. But if some operation reveals that the cache is indeed out-of-sync. It would help even if it wasn't perfect.

[t3chguy]

You can of course write heuristics, but getting a good heuristic for this which doesn't have too many false positives will probably be an artform in itself. You're guessing at best, unless you ask the server for what it thinks and comparing, which will increase server load a lot.

[hifi]

There are two clear cases for cache inconsistency that are user facing:

• joining a room you're already on
• leaving a room you've already left

These can't be resolved with any other mean than clearing the cache AFAIK so when the client and server disagree on this the user could be presented with a choice: "Seems like your client state is not in sync with the server, we can reset your client automatically but it will take a while, proceed?" (rephrased better).

[Penguin-Guru]

It would be nice if this could also warn users how long the operation could take. I'm running one right now that's over an hour in. The window has been pure white with the same spinner in the center the entire time, so I assume it's working.

[t3chguy]

It would be nice if this could also warn users how long the operation could take.

Well the warning would have to be "If your server has insufficient resources it might take longer than you remain alive" given there's no way to know how long it will take

[Penguin-Guru]

It would be nice if this could also warn users how long the operation could take.

Well the warning would have to be "If your server has insufficient resources it might take longer than you remain alive" given there's no way to know how long it will take

That sounds good to me. In my case, I had to kill the process after letting it run for about 26 hours. It seems there was a malfunction but I can't be sure.