Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't copy/paste aliases from the timeline into the composer anymore for commands #7032

Closed
turt2live opened this issue Jul 16, 2018 · 17 comments · Fixed by matrix-org/matrix-react-sdk#2070
Labels
T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter

Comments

@turt2live
Copy link
Member

I often highlight aliases in the timeline so I can /join them more easily. The composer now pastes the alias as a markdown link, which the /join command obviously doesn't like.

@turt2live
Copy link
Member Author

Also happens when pasting a plain link into the composer, which is super annoying.

@t3chguy
Copy link
Member

t3chguy commented Jul 17, 2018

/me would recommend Control Shift V
not sure what the desired outcome is here, as the composer is in a way doing the right thing
just is annoying

@t3chguy
Copy link
Member

t3chguy commented Jul 17, 2018

(I cannot repro it on plain links)
t

@turt2live
Copy link
Member Author

asjdh
image

@t3chguy
Copy link
Member

t3chguy commented Jul 17, 2018

right so we have different definitions of

plain link

I would argue the Composer is doing the right thing here, since you are not pasting plaintext

@turt2live
Copy link
Member Author

Not sure what I was smoking to think it was a plain link. Maybe copy/pasted from the timeline?

@t3chguy
Copy link
Member

t3chguy commented Jul 17, 2018

at which point it'll have been linkified :/

@t3chguy
Copy link
Member

t3chguy commented Jul 17, 2018

It was concluded this is a feature, it's how gmail, google docs etc function. If you wish to avoid it, Control Shift V

@turt2live
Copy link
Member Author

That's a very silly feature to be completely honest. If this was a truly rich editor, I wouldn't mind it automatically linkifying for me - that's actually useful. Given this is a markdown entry, I'd rather it be representative of plain text and therefore require my manual effort to have this stuff happen.

@t3chguy
Copy link
Member

t3chguy commented Jul 17, 2018

It's not automatically linkifying for you though, it's representing what you pasted. Imagine I post <a href="https://...">this</a>
The old composer paste would have pasted "this" now it pastes exactly what you copied: a link

@turt2live
Copy link
Member Author

That's completely backwards in my perspective: I would have copied the text "this", not a link. If I wanted the link, I would have asked for the link via a context menu :/

It's clear that I'm nto going to win this fight though - Can it at least be an option? I'd really like to just have the composer be as close as possible to "just send the text I want to send without being helpful".

@t3chguy
Copy link
Member

t3chguy commented Jul 17, 2018

That's not down to me, it was M's doing

@t3chguy
Copy link
Member

t3chguy commented Jul 17, 2018

/me personally likes things being options so people can be happier with how they use riot

@lampholder lampholder added T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter type:composer labels Jul 18, 2018
@lampholder
Copy link
Member

Flagged as bug question because at the moment there isn't really a satisfactory combination of labels that represent this I think.

@turt2live
Copy link
Member Author

My understanding is that rich pasting is being turned off (yay!), however as another data point: the "Copy Permalink" option on github results in slate trying to wrap the URL in a code block, followed by a ton of extra newlines.

@t3chguy t3chguy closed this as completed Jul 19, 2018
@lampholder
Copy link
Member

Which 'Copy permalink' thing is that?

@turt2live
Copy link
Member Author

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect X-Needs-Info This issue is blocked awaiting information from the reporter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants