Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some direct chat rooms without avatar show my avatar #7235

Closed
madduck opened this issue Aug 28, 2018 · 10 comments · Fixed by matrix-org/matrix-react-sdk#2146
Closed

Some direct chat rooms without avatar show my avatar #7235

madduck opened this issue Aug 28, 2018 · 10 comments · Fixed by matrix-org/matrix-react-sdk#2146
Labels
A-Avatar A-Room-List P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression

Comments

@madduck
Copy link

madduck commented Aug 28, 2018

It is my understanding that rooms used for a direct chat (i.e. those with just one other party in the room, not necessarily those tagged direct-chat) will display the name of the other party, as well as their avatar, if those aren't explicitly set.

While this works for most rooms (I am using /develop), there are a handful of unnamed rooms that correctly display the name of the other party, but they also show my avatar, not theirs. I have tried setting an avatar explicitly (which gets shown), then removing that again, but the result stays the same.

This only applies to some rooms, and I cannot figure out what it is about these rooms that distinguishes them from the other rooms, where the other party's avatar is displayed, as it should.

FWIW, the correct avatar is shown in Riot-Android.

@bwindels
Copy link
Contributor

@madduck do you have "Increase performance by only loading room members on first view" enabled in the lab settings?

@bwindels
Copy link
Contributor

@madduck do you have the issue only with rooms marked as DM (e.g. appearing under People), non-DM but just with two people in it, or both?

@tulir
Copy link
Contributor

tulir commented Aug 29, 2018

I have the issue in 29 out of 114 1:1 rooms. Lazy loading is not enabled.

@madduck
Copy link
Author

madduck commented Aug 29, 2018

I do not have that lazy loading enabled, and I think clearing the cache would have addressed that.

I only see this in DM rooms. Curiously, when I clear the DM flag, the avatar gets loaded properly. If I then reset the DM flag to on, there is no avatar shown (but just the initial letter in a circle).

@madduck
Copy link
Author

madduck commented Aug 29, 2018

Restarting the browser, the avatar is now back to mine (when it should be theirs). Upon mouse-over, it changes to the initial letter in the room list only. It stays as mine in the room header (main pane).

I can also confirm that this is not the case with /app.

@bwindels
Copy link
Contributor

Ok, thanks for the info. This seems to be wrong m.direct account data, marking some rooms as a DM with yourself. Working on a fix.

@bwindels
Copy link
Contributor

matrix-org/matrix-js-sdk#706 & matrix-org/matrix-react-sdk#2141 should fix this.

@bwindels
Copy link
Contributor

Please reopen if you still see this once the fix is available on /develop

@dbkr
Copy link
Member

dbkr commented Sep 3, 2018

#7269 seems to be this, so re-opening.

@turt2live
Copy link
Member

Presuming fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Avatar A-Room-List P1 S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect X-Regression
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants