Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E message keys disappeared from Riot Web and can't be requested #7734

Closed
jryans opened this issue Nov 22, 2018 · 5 comments
Closed

E2E message keys disappeared from Riot Web and can't be requested #7734

jryans opened this issue Nov 22, 2018 · 5 comments

Comments

@jryans
Copy link
Collaborator

jryans commented Nov 22, 2018

Description

I am in an encrypted room that I have used successfully in the past with Riot Web and iOS. However, something has changed, and now the messages are only viewable on Riot iOS. On Riot Web, it acts as if the message keys are missing. When I click to request them, nothing seems to happen. (In the console, I can observe that it appears to get keys, but the messages remain hidden)

Curiously, if I try riot.im/develop, some of the older messages do appear. With riot.im/app, none of the older messages will appear.

Steps to reproduce

  • Create an encrypted room with several devices
  • Something happens causing a device to lose keys
  • Try to re-request message keys

I would expect the message keys to be requested successfully and the messages to re-appear. Currently, they seem to be broken with no path to recovery.

Version information

  • Platform: web
  • Browser: Firefox 65
  • OS: macOS 10.13.6
  • URL: riot.im/app shows no older messages, riot.im/develop shows some but not all
@jryans
Copy link
Collaborator Author

jryans commented Nov 22, 2018

I have sent debug logs from my end.

I do see messages like "room key request for unknown session ..." in the console, which perhaps is related to the problem.

@jryans
Copy link
Collaborator Author

jryans commented Nov 22, 2018

I was able to manually export room keys from iOS and import them into Web successfully. The messages are now viewable in Web again, so that's great, but I wonder what even was wrong to start with.

Perhaps I corrupted some state by switching between /app and /develop in the same browser?

@lampholder
Copy link
Member

Dave's taking a look into this now :)

If I understand it correctly, there should be measures in place to stop E2E state being corrupted by switching between Riot versions (by warning you if there's an incompatibility), though of course it's possible that there's a problem in that code.

Anyway, I'm glad importing the keys has overcome the immediate hurdle - we'll try and find out what caused this in the first place.

@jryans
Copy link
Collaborator Author

jryans commented Nov 22, 2018

I guess there's actually still an issue remaining: Riot Web can't seem to get new message keys automatically any more. So, the manual import works, but then new messages are still broken. So, I would need to keep repeating the process of manually exporting and importing keys to see new messages.

@jryans
Copy link
Collaborator Author

jryans commented Nov 22, 2018

@dbkr guessed it was a version corruption issue between /app and /develop. And indeed, if I stay on /develop, everything works as intended even for new messages.

I filed #7735 to handle the root cause of version confusion across multiple app branches on the same domain, so I think this can be closed.

@jryans jryans closed this as completed Nov 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants