Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications triggered by keywords don't decorate messages - Highlight keywords in a pill #8821

Open
nadonomy opened this issue Feb 20, 2019 · 5 comments · May be fixed by #28270
Open

Notifications triggered by keywords don't decorate messages - Highlight keywords in a pill #8821

nadonomy opened this issue Feb 20, 2019 · 5 comments · May be fixed by #28270
Labels
A-Notifications A-Pills O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design Z-FTUE-Notifications Z-GetYourUpdates

Comments

@nadonomy
Copy link
Contributor

Should follow the same convention as @mention decoration— currently with the notifying word in a pill and the entire message highlighted red.
@AmandineLP
Copy link
Contributor

Doesn't look like it does anything really:
I configured a keyword and ask someone to mention it but I had no noisy notifs nor visual highlight.

@nadonomy
Copy link
Contributor Author

In the Electron (macOS) build I got a system level notification— if you're in a browser it's worth investigating if the browser suppressed it?

@turt2live turt2live mentioned this issue Mar 6, 2019
Open
@MadLittleMods MadLittleMods changed the title Notifications triggered by keywords don't decorate messages Notifications triggered by keywords don't decorate messages - Highlight keywords in a pill Jun 17, 2021
@MadLittleMods MadLittleMods mentioned this issue Jun 17, 2021
Closed
@MadLittleMods
Copy link
Contributor

https://www.figma.com/file/M15i7l4PSPY1B5M7Zhu80H/Notifications?node-id=547%3A3122

-- #13964 (comment)

@ssbarnea
Copy link

The lack of any kind of highlighting on mentions/keywords, makes the client almost impossible to use with active channels. People endup thinking that you ignore them when in fact your fail to spot the messages.

@MadLittleMods MadLittleMods added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Occasional Affects or can be seen by some users regularly or most users rarely labels Apr 14, 2022
@MadLittleMods MadLittleMods mentioned this issue Apr 14, 2022
Open
@Pwuts
Copy link

Pwuts commented Jun 27, 2022

I'm getting notifications (both on mobile and desktop) for keyword highlights, but when I open the client I have to (often painstakingly) search for the message because it isn't decorated. Mentions work fine.

@clokep clokep mentioned this issue Mar 24, 2023
Closed
@taffyko taffyko mentioned this issue Sep 23, 2024
Closed
4 tasks
@taffyko taffyko linked a pull request Oct 22, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Notifications A-Pills O-Occasional Affects or can be seen by some users regularly or most users rarely S-Minor Impairs non-critical functionality or suitable workarounds exist T-Enhancement X-Needs-Design Z-FTUE-Notifications Z-GetYourUpdates
Projects
None yet
Milestone
No milestone
8 participants
@ssbarnea @jryans @MadLittleMods @lampholder @nadonomy @AmandineLP @Pwuts @daniellekirkwood