Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing the read marker automatically after ~30 seconds makes it difficult to manage unread messages #9131

Open
benparsons opened this issue Mar 12, 2019 · 3 comments
Labels
A-Read-Marker Green line showing how far _you_ have read O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Needs-Design Z-WTF

Comments

@benparsons
Copy link
Member

Description

Clearing the read marker automatically after ~30 seconds makes it difficult to manage unread messages. The little green dot + arrow in the top right disappears after entering a room, and with it goes your read marker.

Steps to reproduce

  • Enter a room with many unread messages
  • start reading the most recent messages
  • your read marker disappears
  • now you can't go back to find your unread messages

Version information

acacc61-react-7eea62a22ba9-js-90670cf1be0f

  • Platform: web/desktop
@lampholder lampholder added T-Defect P1 S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Needs-Product More input needed from the Product team A-Read-Marker Green line showing how far _you_ have read labels Mar 15, 2019
@ara4n
Copy link
Member

ara4n commented Sep 23, 2019

@MadLittleMods
Copy link
Contributor

MadLittleMods commented Feb 28, 2022

Luckily, I haven't noticed this problem (very subtle and indirect) until reading the issue but I see it now 🙈. What's the goal of having this? It doesn't seem useful to me and my initial hunch was just to rip it out (cc @bwindels). I don't want to lose my position just because I switched to a room and left the app open. And the follow-up issue #8057 to change this to only clear after 30s and then switching rooms kinda boosts the point that this isn't very friendly atm.

It's even a setting: Settings -> Preferences -> General section -> Read Marker lifetime (ms) and Read Marker off-screen lifetime (ms)

  • readMarkerInViewThresholdMs
  • readMarkerOutOfViewThresholdMs

This setting will make the jump to unreads arrow button disappear after 30 seconds:

Dev notes

Introduced in matrix-org/matrix-react-sdk#2345 (originally in matrix-org/matrix-react-sdk#2322 that has some context)

Made as a configurable setting in matrix-org/matrix-react-sdk#3450

Ftr, I talked @AmandineLP through this yesterday and she has concerns about ever destroying off-screen bookmarks, although I think we should how this feels first before we creep it in future towards the full "track all RM bookmarks" solution.

-- @ara4n, matrix-org/matrix-react-sdk#2322 (comment)

And then #8057 mentions even improving the situation of not clearing until after 30s and you switch rooms. But seems like the simpler option would be to just remove this feature of clearing altogether.

@robertlong robertlong added O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience and removed P1 labels Apr 27, 2022
@novocaine novocaine added S-Tolerable Low/no impact on users X-Needs-Design and removed S-Major Severely degrades major functionality or product features, with no satisfactory workaround X-Needs-Product More input needed from the Product team labels Apr 28, 2022
@vertigo220
Copy link

I would also just like to add that the purpose of these settings and the autocomplete delay one aren't clear, and I had to do a search just to figure out what they even do. There should be a tooltip or something for more obscure settings like this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Read-Marker Green line showing how far _you_ have read O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Tolerable Low/no impact on users T-Defect X-Needs-Design Z-WTF
Projects
None yet
Development

No branches or pull requests

8 participants