Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions: Add emoji picker as a message action #9483

Closed
jryans opened this issue Apr 15, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#3554
Closed

Reactions: Add emoji picker as a message action #9483

jryans opened this issue Apr 15, 2019 · 3 comments · Fixed by matrix-org/matrix-react-sdk#3554

Comments

@jryans
Copy link
Collaborator

jryans commented Apr 15, 2019

Screenshot 2019-05-17 at 13 56 14

Currently we're thinking we'll use https://github.com/missive/emoji-mart.

To open the emoji picker:

  • Clicking (🙂+) reveals the emoji picker
  • Clicking 'View all' reveals the emoji picker
@turt2live
Copy link
Member

Would be great if it was added in such a way where matrix-org/matrix-spec-proposals#1959 could be supported in future.

Note from the proposal:

Although this proposal does not include an emoji picker definition, the API it proposes can easily and transparently be extended to such a widget.

@jryans jryans self-assigned this Apr 26, 2019
@jryans jryans changed the title Reactions: Integrate emoji picker Reactions: Add emoji picker as a message action Apr 26, 2019
@jryans
Copy link
Collaborator Author

jryans commented Apr 26, 2019

Would be great if it was added in such a way where matrix-org/matrix-doc#1959 could be supported in future.

As fas as I can see, we should be able to the extend the picker component with custom data sets to achieve this. It may take some amount of customising / forking to do so, but I think that's acceptable.

@poperigby
Copy link

It would probably be a good idea to have the emoji picker in the right-click menu as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants