Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message editing composer - doesn't work well with IMEs (on Firefox OS X Chinese) #9740

Closed
lampholder opened this issue May 16, 2019 · 5 comments

Comments

@lampholder
Copy link
Member

Screen Recording 2019-05-16 at 12 06 35 2019-05-16 12_08_16

In the gif I:

  • open a message for editing
  • my cursor is directly adjacent to a non-whitespace character
  • I start typing pinyin
  • the roman characters are swallowed as I type
  • pressing space to submit the chinese characters at the end doesn't actually send the characters

However - it isn't broken in all cases - if you type a space character first, the roman characters are not swallowed and the chinese is submitted correctly.

@wcjwing
Copy link

wcjwing commented Jul 29, 2019

Same case occured on Riot Windows 10 Simple Chinese, the first input character is always ignored and some characters is missing from IMEs randomly.

For GIF case, what I really want to input is "今天你好吗,怎么样?“
BwVNdaHKXN

@jryans
Copy link
Collaborator

jryans commented Jul 30, 2019

@wcjwing This issue is about the composer for edits, which is (currently) separate from the composer for normal messages. Your video above seems to show the composer for regular messages, and it's a known issue that it fails for IMEs and many other cases too.

We hope to solve #7665 by replacing the regular composer with the one for edits, so please do check out the IME compatibility of the new editing composer (which would be related to this issue).

@bwindels
Copy link
Contributor

bwindels commented Aug 22, 2019

@lampholder I've tried to reproduce with Firefox 68 on macOS 10.14.4 (Mojave) and all seems to work well:

chinese

Also tried on Chrome with same result.

@aaronraimist
Copy link
Collaborator

Related: #10646

@bwindels
Copy link
Contributor

bwindels commented Sep 2, 2019

Assuming this is fixed, as #10646 is.

@bwindels bwindels closed this as completed Sep 2, 2019
@jryans jryans removed the Z-UI/UX label Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants