[Compound] Implement dialogs #1043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinesp
changed the title
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #1043 +/- ##
===========================================
- Coverage 56.88% 56.88% -0.01%
===========================================
Files 997 997
Lines 25392 25321 -71
Branches 5117 5078 -39
===========================================
- Hits 14444 14403 -41
+ Misses 8703 8692 -11
+ Partials 2245 2226 -19
☔ View full report in Codecov by Sentry. |
jmartinesp
force-pushed
the
chore/jme/compound-platform-components-dialog
branch
from
bb6fb6f
to
9ef3d4e
Compare
jmartinesp
requested review from
bmarty,
a team and
julioromano
and removed request for
a team and
bmarty
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
TextButtonpadding smaller when it doesn't have an icon.AlertDialogContenttotheme/componentsto make it part of the 'platform components' instead of having it as a custom component.Closes element-hq/compound#202.
Note: this PR only covers simple dialogs, and doesn't try to implement dialogs containing lists since the work on lists is paused. Also, this PR does not handle 'disabled' state for buttons since I couldn't verify the behavior needed, so this will be added in a separate PR in the future.