[Compound] Implement DropdownMenu customisations. #1050

jmartinesp · 2023-08-10T11:48:48Z

Changes

Remove DropdownMenuItemText since we can get the same results by just providing the text style.
Apply Figma designs.
Make sure multi-line menu items look good.

github-actions · 2023-08-10T12:03:53Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/QXPbSC

codecov · 2023-08-10T12:12:02Z

Codecov Report

Patch coverage: 70.96% and project coverage change: +0.02% 🎉

Comparison is base (e600b05) 56.88% compared to head (35a774a) 56.90%.
Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1050      +/-   ##
===========================================
+ Coverage    56.88%   56.90%   +0.02%     
===========================================
  Files          997      997              
  Lines        25392    25402      +10     
  Branches      5117     5112       -5     
===========================================
+ Hits         14444    14456      +12     
- Misses        8703     8705       +2     
+ Partials      2245     2241       -4

Files Changed	Coverage Δ
...droid/features/roomdetails/impl/RoomDetailsView.kt	`56.36% <ø> (ø)`
...eatures/roomlist/impl/components/RoomListTopBar.kt	`47.88% <ø> (ø)`
.../designsystem/theme/components/DropdownMenuItem.kt	`66.66% <68.96%> (+21.50%)`	⬆️
...ries/designsystem/theme/components/DropdownMenu.kt	`60.00% <100.00%> (-8.43%)`	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

julioromano · 2023-08-11T12:25:49Z

...c/main/kotlin/io/element/android/libraries/designsystem/theme/components/DropdownMenuItem.kt

@@ -39,12 +46,23 @@ fun DropdownMenuItem(
    leadingIcon: @Composable (() -> Unit)? = null,
    trailingIcon: @Composable (() -> Unit)? = null,
    enabled: Boolean = true,
-    colors: MenuItemColors = MenuDefaults.itemColors(),
-    contentPadding: PaddingValues = MenuDefaults.DropdownMenuItemContentPadding,
+    colors: MenuItemColors = MenuDefaults.itemColors(


Should we remove this param from the public API?
In #1043 it looks like you created an internal "defaults" object and removed the now unneeded params from the public API of the composable.