Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing plugin forward between LoggedInAppScopeFlowNode and LoggedInFlowNode #1160

Merged
merged 2 commits into from
Aug 28, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Aug 28, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

The RoomComponent was not created.

Motivation and context

Fix crash when opening a room since #1149 has been merged.

Screenshots / GIFs

Tests

  • Open a room, observe that the app does not crash anymore.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

…ggedInFlowNode`. The RoomComponent was not created.

Fix crash when opening a room.
@bmarty bmarty requested a review from a team as a code owner August 28, 2023 14:58
@bmarty bmarty requested review from jmartinesp and removed request for a team August 28, 2023 14:58
Copy link
Member

@jmartinesp jmartinesp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! We should find a way to ensure we always pass lifecycle plugins down in flow nodes maybe?

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/f9KbUA

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (29465f4) 56.87% compared to head (a700f11) 56.87%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1160   +/-   ##
========================================
  Coverage    56.87%   56.87%           
========================================
  Files         1039     1039           
  Lines        26812    26812           
  Branches      5544     5544           
========================================
  Hits         15248    15248           
  Misses        9168     9168           
  Partials      2396     2396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@bmarty bmarty merged commit 86ad01c into develop Aug 28, 2023
13 of 16 checks passed
@bmarty bmarty deleted the feature/bma/fixOpeningRoomCrash branch August 28, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants