Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reply action: harmonize condition #1173

Closed
bmarty opened this issue Aug 29, 2023 · 0 comments · Fixed by #1271
Closed

Reply action: harmonize condition #1173

bmarty opened this issue Aug 29, 2023 · 0 comments · Fixed by #1271
Assignees
@bmarty
Labels
A-Reply O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Polish

Comments

@bmarty
Copy link
Member

bmarty commented Aug 29, 2023

There are 2 places were we compute if a message can be replied or not:

  • In the ActionListPresenter, here, for the action displayed when long pressing on an Event

  • and in the TimelinePresenter here, as a global boolean for the timeline, to enable or not the swipe gesture to trigger the reply mode.

All of this is valid, but incomplete. We should create a helper to compute if replying to a message is possible. Also this helper could consider the message type to prevent reply on some of them. If centralized this is easier.

Currently under certain circumstance, the reply may be possible on one place and not in the other, i.e. not in the ActionList, but gesture is enabled, or in the ActionList, but gesture is not available.
@bmarty bmarty added S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems O-Uncommon Most users are unlikely to come across this or unexpected workflow A-Reply labels Aug 29, 2023
@bmarty bmarty self-assigned this Sep 11, 2023
@bmarty bmarty mentioned this issue Sep 11, 2023
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmarty bmarty

Labels
A-Reply O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems Z-Polish
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reply action: harmonize condition element-hq/element-x-android
2 participants
@kittykat @bmarty