Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use roomInfo instead of individually access roomListItem properties #1251

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Sep 7, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Use RoomInfo instead of accessing all properties of RoomListItem. It should speed up mapping.

@ganfra ganfra marked this pull request as ready for review September 7, 2023 13:55
@ganfra ganfra requested a review from a team as a code owner September 7, 2023 13:55
@ganfra ganfra requested review from bmarty and removed request for a team September 7, 2023 13:55
@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/i4jWsK

@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01% 🎉

Comparison is base (33dd0b2) 57.71% compared to head (a3940dd) 57.72%.
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1251      +/-   ##
===========================================
+ Coverage    57.71%   57.72%   +0.01%     
===========================================
  Files         1078     1078              
  Lines        28038    28033       -5     
  Branches      5777     5775       -2     
===========================================
  Hits         16181    16181              
+ Misses        9330     9325       -5     
  Partials      2527     2527              
Files Changed Coverage Δ
.../matrix/impl/roomlist/RoomSummaryDetailsFactory.kt 0.00% <0.00%> (ø)
...s/matrix/impl/roomlist/RoomSummaryListProcessor.kt 0.00% <0.00%> (ø)
...raries/matrix/impl/roomlist/RustRoomListService.kt 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe add a changelog?

@ganfra ganfra force-pushed the feature/fga/room-list-room-info branch from 50d7715 to a3940dd Compare September 7, 2023 18:44
@sonarcloud
Copy link

sonarcloud bot commented Sep 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ganfra ganfra merged commit d8478da into develop Sep 7, 2023
13 of 14 checks passed
@ganfra ganfra deleted the feature/fga/room-list-room-info branch September 7, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants