[Rich text editor] Add link functionality to rich text editor

[jonnyandrew]

Type of change

• Feature
• Bugfix
• Technical
• Other :

Content

• Add link functionality to rich text editor
• Add 'list dialog' component compound design library
• Add 'text field list item' component to compound design library

Motivation and context

• [Story] Add/edit/delete a link using the RTE in EX element-meta#1975

Screenshots / GIFs

See screenshot tests

Tests

• Enable rich text editor in developer options
• Start composing a message
• Add a link using the new button
• Edit the link using the new button
• Remove the link using the new button
• Send a message containing a link
• Edit a message containing a link

Tested devices

• Physical
• Emulator
• OS version(s): 13

Checklist

• Changes have been tested on an Android device or Android emulator with API 23
• UI change has been tested on both light and dark themes
• Accessibility has been taken into account. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
• Pull request is based on the develop branch
• Pull request includes a new file under ./changelog.d. See https://github.com/vector-im/element-x-android/blob/develop/CONTRIBUTING.md#changelog
• Pull request includes screenshots or videos if containing UI changes
• Pull request includes a sign off
• You've made a self review of your PR

[github-actions]

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/d9uo9m

[codecov]

Codecov Report

Patch coverage: 44.23% and project coverage change: -0.07% ⚠️

Comparison is base (1eb9491) 57.81% compared to head (e26f76a) 57.74%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1309      +/-   ##
===========================================
- Coverage    57.81%   57.74%   -0.07%     
===========================================
  Files         1120     1123       +3     
  Lines        29774    29970     +196     
  Branches      6114     6174      +60     
===========================================
+ Hits         17213    17307      +94     
- Misses        9876     9940      +64     
- Partials      2685     2723      +38     

Files Changed	Coverage Δ
...ent/android/libraries/textcomposer/TextComposer.kt	53.15% <3.84%> (-1.77%)	⬇️
...ries/designsystem/components/dialogs/ListDialog.kt	44.68% <44.68%> (ø)
...d/libraries/textcomposer/TextComposerLinkDialog.kt	50.00% <50.00%> (ø)
.../designsystem/components/list/TextFieldListItem.kt	66.66% <66.66%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[jmartinesp]

Should the link dialog pre-set the selected text (if any) as the text for the link? It doesn't seem to be working.

[jmartinesp]

Besides the possible issue with inserting a link not taking the selected text, I have a few questions and suggestions.

[ElementBot]

	Warnings
⚠️	gradle/libs.versions.toml#L99 - A newer version of androidx.compose.material3:material3 than 1.2.0-alpha06 is available: 1.2.0-alpha07
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L160 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-cs/translations.xml#L165 - For locale "cs" (Czech) the following quantity should also be defined: many (e.g. "10.0 dne")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L173 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")
⚠️	libraries/ui-strings/src/main/res/values-sk/translations.xml#L178 - For locale "sk" (Slovak) the following quantity should also be defined: many (e.g. "10.0 dňa")

Generated by 🚫 dangerJS against e26f76a

[jonnyandrew]

Should the link dialog pre-set the selected text (if any) as the text for the link? It doesn't seem to be working.

The rich text editor is still limited in that respect and it's not possible to preview or edit the selected text when editing links.

However, in the version you tested there is a bug where the dialog may incorrectly display an empty text field when selecting text; this makes the problem much worse UX wise and I suspect this is what you saw. I've since updated to version 2.10.2 which contains a fix for this if you wanted to try this.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[jonnyandrew]

@jmartinesp / @bmarty thanks for your reviews - I have addressed the issues

[bmarty]

Tested OK, thanks. There are conflict on the strings (sorry), maybe run again the localazy script?