Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update app icon #1363

Merged
merged 3 commits into from
Sep 18, 2023
Merged

Update app icon #1363

merged 3 commits into from
Sep 18, 2023

Conversation

bmarty
Copy link
Member

@bmarty bmarty commented Sep 18, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other : design integration

Content

New app icon, imported from https://www.figma.com/file/23EMkl4apCrdaf71d3EPe6/Android-App-Icons?type=design&node-id=0-1&mode=design&t=N1E45eRz8OawKMjM-0
Including monochrome icon (see #1265)
Also fixes #1089

Motivation and context

Screenshots / GIFs

Tests

  • run the app and observe the new icon.

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from a team as a code owner September 18, 2023 13:19
@bmarty bmarty requested review from julioromano and removed request for a team September 18, 2023 13:19
contentDescription = null
)
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to @julioromano : not part of screenshot test since it is in the app module. But useful for preview in AS.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sadly GitHub does not render wepb file :/

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

github.dev does :)

@github-actions
Copy link
Contributor

github-actions bot commented Sep 18, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/a9rjGc

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (1d65cc9) 57.75% compared to head (ae9ecd9) 57.75%.
Report is 2 commits behind head on develop.

❗ Current head ae9ecd9 differs from pull request most recent head b803666. Consider uploading reports for the commit b803666 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1363   +/-   ##
========================================
  Coverage    57.75%   57.75%           
========================================
  Files         1120     1120           
  Lines        29719    29719           
  Branches      6102     6102           
========================================
  Hits         17163    17163           
  Misses        9873     9873           
  Partials      2683     2683           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ElementBot
Copy link
Collaborator

ElementBot commented Sep 18, 2023

Warnings
⚠️

tools/lint/lint.xml#L34 - Issue IconExpectedSize was configured with severity error in uitests, but was not enabled (or was disabled) in library di

⚠️

tools/lint/lint.xml#L73 - Issue NegativeMargin was configured with severity error in uitests, but was not enabled (or was disabled) in library di

⚠️

tools/lint/lint.xml#L87 - Issue KotlinPropertyAccess was configured with severity error in uitests, but was not enabled (or was disabled) in library di

⚠️

tools/lint/lint.xml#L123 - Unknown issue id "EnsureInitializerMetadata"

Generated by 🚫 dangerJS against b803666

@bmarty bmarty merged commit 69b57b8 into develop Sep 18, 2023
11 checks passed
@bmarty bmarty deleted the feature/bma/appIcon branch September 18, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly and debug builds should have different icons
3 participants