New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element call tweaks #1434

Merged

bmarty merged 4 commits into develop from feature/bma/elementCallTweaks

Sep 27, 2023

Member

bmarty commented Sep 26, 2023

Android equivalent for element-hq/element-x-ios#1791

bmarty added 2 commits

September 26, 2023 15:41


          Element call URL must have https scheme.

f0d5c46


          Element call: Pass in custom call URL query parameters

8cb7c32

bmarty requested a review from dbkr

September 26, 2023 14:21

bmarty requested a review from a team as a code owner

September 26, 2023 14:21

bmarty requested review from julioromano and removed request for a team

September 26, 2023 14:21


          Changelog

39a2e2a

Contributor

github-actions bot commented Sep 26, 2023 •

edited

Loading

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3TE4cZ

codecov bot commented Sep 26, 2023 •

edited

Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (6e422cc) 58.04% compared to head (5d0751d) 58.06%.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1434      +/-   ##
===========================================
+ Coverage    58.04%   58.06%   +0.01%     
===========================================
  Files         1129     1129              
  Lines        29938    29948      +10     
  Branches      6089     6092       +3     
===========================================
+ Hits         17378    17388      +10     
  Misses        9953     9953              
  Partials      2607     2607

Files	Coverage Δ
...ment/android/features/call/CallIntentDataParser.kt	`92.00% <93.33%> (+5.33%)`	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmarty added the Z-NextRelease label


          Detekt: sentences must end with a period.

5d0751d

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

julioromano approved these changes

View reviewed changes

bmarty merged commit 161c6d0 into develop

15 checks passed

bmarty deleted the feature/bma/elementCallTweaks branch

September 27, 2023 08:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels