Room : makes subscribeToSync/unsubscribeFromSync suspendable #1457

ganfra · 2023-09-28T18:18:48Z

Rework how we use subscribe/unsubscribe on sync.
Previously the calls were synced and on the main thread, which could lead to break the navigation animation or even causes some ANR.
This is now handled properly with suspendable, and we keep a subscription count to avoid messing with the asynchronous nature of node lifecycle and coroutines.

…s sure we keep subscription count

github-actions · 2023-09-28T18:36:03Z

📱 Scan the QR code below to install the build (arm64 only) for this PR.

If you can't scan the QR code you can install the build via this link: https://i.diawi.com/9XhWtN

codecov · 2023-09-28T19:35:23Z

Codecov Report

Attention: 45 lines in your changes are missing coverage. Please review.

Comparison is base (ce96c73) 57.92% compared to head (a84e823) 57.85%.
Report is 14 commits behind head on develop.

❗ Current head a84e823 differs from pull request most recent head d837b33. Consider uploading reports for the commit d837b33 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1457      +/-   ##
===========================================
- Coverage    57.92%   57.85%   -0.07%     
===========================================
  Files         1129     1130       +1     
  Lines        30046    30080      +34     
  Branches      6144     6148       +4     
===========================================
  Hits         17404    17404              
- Misses       10031    10065      +34     
  Partials      2611     2611

Files	Coverage Δ
...nt/android/libraries/matrix/api/room/MatrixRoom.kt	`28.57% <ø> (ø)`
.../android/libraries/matrix/impl/RustMatrixClient.kt	`0.00% <0.00%> (ø)`
...droid/libraries/matrix/test/room/FakeMatrixRoom.kt	`90.77% <0.00%> (ø)`
...droid/libraries/matrix/impl/room/RustMatrixRoom.kt	`0.00% <0.00%> (ø)`
...d/libraries/matrix/impl/room/RoomSyncSubscriber.kt	`0.00% <0.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bmarty

LGTM, thanks. Maybe add an entry for the changelog? Not sure since it does not change anything for the user, but it may help to investigate regression (if any!)