-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve session db and improve deleted session behavior #1520
Conversation
rustMatrixClientFactory.create(sessionData) | ||
} else { | ||
error("Token is not valid") | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sometimes a Push can trigger this, and the Sdk ends up in a messed up state. So avoid restoring a MatrixClient if we know that the token is not valid anymore.
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
ce815f8
to
2d280ab
Compare
…support for soft-logout)
Generate database with model version 4
2d280ab
to
ad35119
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1520 +/- ##
===========================================
+ Coverage 58.98% 58.99% +0.01%
===========================================
Files 1133 1142 +9
Lines 30316 30479 +163
Branches 6215 6245 +30
===========================================
+ Hits 17882 17982 +100
- Misses 9761 9801 +40
- Partials 2673 2696 +23
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work thanks!
ad35119
to
8be6bad
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Type of change
Content
Motivation and context
Working on element-hq/element-android#8663, I realized that some fields was missing to migrate data properly. This PR adds 2 fields to SessionData. Also adding unit test for the database migration (automatically added to the gradle
test
task).Part of #1154 (no soft logout support)
Will add string to localazy once the wording will be approved.
Screenshots / GIFs
See recorded screenshot
Tests
Tested devices
Checklist