Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default enable voice message feature flag #1669

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Default enable voice message feature flag #1669

merged 1 commit into from
Oct 27, 2023

Conversation

julioromano
Copy link

:party

@julioromano julioromano requested a review from a team as a code owner October 27, 2023 14:51
@julioromano julioromano requested review from ganfra and removed request for a team October 27, 2023 14:51
@julioromano julioromano self-assigned this Oct 27, 2023
bmarty
bmarty reviewed Oct 27, 2023
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not enable in production app, if this is what you want to achieve (?)

...featureflag/api/src/main/kotlin/io/element/android/libraries/featureflag/api/FeatureFlags.kt
@@ -47,7 +47,7 @@ enum class FeatureFlags(
key = "feature.voicemessages",
title = "Voice messages",
description = "Send and receive voice messages",
defaultValue = false,
defaultValue = true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you read the comment at line 21? 😛

@julioromano
Copy link
Author

This does not enable in production app, if this is what you want to achieve (?)

Fixed, Thanks :)

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/ZT5Fjj

@julioromano julioromano enabled auto-merge (squash) October 27, 2023 15:16
@julioromano julioromano merged commit c3cbf4d into develop Oct 27, 2023
13 of 14 checks passed
@julioromano julioromano deleted the julioromano/remove_voic_flag branch October 27, 2023 15:16
@bmarty
Copy link
Member

bmarty commented Oct 27, 2023

I forgot to mention it, but maybe add an file for a changelog for that? It will be more visible in the release note when we will do the release.

@julioromano
Copy link
Author

I forgot to mention it, but maybe add an file for a changelog for that? It will be more visible in the release note when we will do the release.

#1674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

@ganfra ganfra Awaiting requested review from ganfra ganfra is a code owner automatically assigned from element-hq/element-x-android-reviewers

Assignees

@julioromano julioromano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julioromano @bmarty