-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update icons #1718
Comments
@jmartinesp and @bmarty I assigned both of you to this not knowing who is best to make these changes. Let me know if you have any questions |
@callumu I can't find this file icon in the set of compound icons or the uploaded ones. Can you point me to it, or tell me what its name is? |
It's called 'Document': https://www.figma.com/file/gkNXqPoiJhEv2wt0EJpew4/Compound-Icons?type=design&node-id=2506%3A1370&mode=design&t=7ZKIkmSCTXeAQaq2-1 |
Ok, thanks. I couldn't find it in the Compound repo, I didn't know this Figma file existed 😅 . |
Another question: @bmarty already added some temporary icons back in September, and some of the ones you provided now in the zip replace a few of those. I'm not entirely sure how these new icons should be added to the project, to be honest. Should we batch import these new icons and replace all the icons from September with these? Should we only replace those that have been replaced in the code, like the 'new message' icon? |
@callumu sorry, I forgot to tag you ⬆️ |
Is it better in your perspective to wait until they've been added to the Compound repo before updating? There are some changes here that replace the ones made in September, but most of them are new |
For us it would definitely be better to just use icons added in Compose, but if we need to use some temporary ones that's also ok. As long ast the names don't change (i.e. "Mention.svg" to "User mention.svg", or something like that) we can probably just replace the old temporary ones with the new ones. |
@callumu so, to sum up: we have the compound icons, then we should have another category of 'temporary' icons that we'll batch import periodically, with some new icons and some others that replace the old ones, right? What about icons that get added to Compound or are no longer used anywhere? Should we remove those, and if so, do we have a way to differentiate them from other imported icons that aren't used yet? |
Yes pretty much.
I'm not sure about this. @janogarcia will probably know better or maybe @kerryarchibald can you help? |
Steps to reproduce
I'll add a load of screenshots to communicate the changes. Any icon with a blue dot next to it is already in the Compound icon repo, otherwise it's in a ZIP file which I'll add to this issue:
Location sharing pin from Figma
ZIP file with other icons:
New icons November 2023.zip
Outcome
What did you expect?
What happened instead?
Your phone model
No response
Operating system version
No response
Application version and app store
No response
Homeserver
No response
Will you send logs?
Yes
Are you willing to provide a PR?
Yes
The text was updated successfully, but these errors were encountered: