-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reply to a poll #1848
Reply to a poll #1848
Conversation
e5ebc8d
to
733c9ec
Compare
User story: element-hq/element-meta#1976
733c9ec
to
c787462
Compare
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1848 +/- ##
========================================
Coverage 63.62% 63.62%
========================================
Files 1314 1314
Lines 34270 34290 +20
Branches 7100 7103 +3
========================================
+ Hits 21803 21816 +13
- Misses 9221 9226 +5
- Partials 3246 3248 +2 ☔ View full report in Codecov by Sentry. |
ce5d590
to
b15f232
Compare
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange that the "Reply" action was already present, I guess the state for the preview was not conform to what could happen in real life. It's OK now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had built it earlier but then didn't enable it because there was a bug in the rust side.
So some of the infrastructure for replies was already in place albeit not finished.
Forgot to add this bit to: #1848
Forgot to add this bit to: #1848
Type of change
Content
Polls can now be replied to.
Motivation and context
User story: element-hq/element-meta#1976
Screenshots / GIFs
Tests
Tested devices
Checklist