Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply to a poll #1848

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Reply to a poll #1848

merged 3 commits into from
Nov 22, 2023

Conversation

julioromano
Copy link

@julioromano julioromano commented Nov 21, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Polls can now be replied to.

Motivation and context

User story: element-hq/element-meta#1976

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@julioromano julioromano self-assigned this Nov 21, 2023
@julioromano julioromano requested a review from a team as a code owner November 21, 2023 21:15
@julioromano julioromano requested review from ganfra and removed request for a team November 21, 2023 21:15
Copy link
Contributor

github-actions bot commented Nov 21, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/3HTV2M

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (de646e4) 63.62% compared to head (b15f232) 63.62%.

Files Patch % Lines
...s/impl/timeline/components/TimelineItemEventRow.kt 7.14% 19 Missing and 7 partials ⚠️
...eatures/messages/impl/actionlist/ActionListView.kt 66.66% 1 Missing and 2 partials ⚠️
...es/messages/impl/actionlist/ActionListPresenter.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1848   +/-   ##
========================================
  Coverage    63.62%   63.62%           
========================================
  Files         1314     1314           
  Lines        34270    34290   +20     
  Branches      7100     7103    +3     
========================================
+ Hits         21803    21816   +13     
- Misses        9221     9226    +5     
- Partials      3246     3248    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange that the "Reply" action was already present, I guess the state for the preview was not conform to what could happen in real life. It's OK now!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had built it earlier but then didn't enable it because there was a bug in the rust side.
So some of the infrastructure for replies was already in place albeit not finished.

@julioromano julioromano merged commit 0f0bd34 into develop Nov 22, 2023
17 of 18 checks passed
@julioromano julioromano deleted the julioromano/polls_reply branch November 22, 2023 09:52
julioromano pushed a commit that referenced this pull request Nov 22, 2023
Forgot to add this bit to: #1848
jmartinesp pushed a commit that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants