Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update poll icons from Compound #1849

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

julioromano
Copy link

@julioromano julioromano commented Nov 22, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Update poll icons from Compound, remove the old ones.

Motivation and context

Story: element-hq/element-meta#2182

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@julioromano julioromano self-assigned this Nov 22, 2023
@julioromano julioromano requested a review from a team as a code owner November 22, 2023 08:06
@julioromano julioromano requested review from bmarty and removed request for a team November 22, 2023 08:06
@julioromano julioromano changed the base branch from develop to julioromano/polls_reply November 22, 2023 08:07
@julioromano
Copy link
Author

Copy link
Contributor

github-actions bot commented Nov 22, 2023

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/GDSV3F

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0f0bd34) 63.62% compared to head (bffafaf) 63.62%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1849   +/-   ##
========================================
  Coverage    63.62%   63.62%           
========================================
  Files         1314     1314           
  Lines        34290    34290           
  Branches      7103     7103           
========================================
  Hits         21816    21816           
  Misses        9226     9226           
  Partials      3248     3248           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard to see the diff here 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rounding of the bars seem a little bit different....

@amshakal can you just give an eye on this screenshots to see if the new poll icons look okay?

Base automatically changed from julioromano/polls_reply to develop November 22, 2023 09:52
@julioromano
Copy link
Author

Updated screenshot incoming after rebase: https://github.com/vector-im/element-x-android/actions/runs/6955630430

Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jmartinesp jmartinesp merged commit 60f58f9 into develop Nov 22, 2023
15 checks passed
@jmartinesp jmartinesp deleted the julioromano/polls_new_icons branch November 22, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants