-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update poll icons from Compound #1849
Conversation
ed7b9b9
to
178e8ee
Compare
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1849 +/- ##
========================================
Coverage 63.62% 63.62%
========================================
Files 1314 1314
Lines 34290 34290
Branches 7103 7103
========================================
Hits 21816 21816
Misses 9226 9226
Partials 3248 3248 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hard to see the diff here 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rounding of the bars seem a little bit different....
@amshakal can you just give an eye on this screenshots to see if the new poll icons look okay?
d050a2c
to
38d5fad
Compare
Updated screenshot incoming after rebase: https://github.com/vector-im/element-x-android/actions/runs/6955630430 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Type of change
Content
Update poll icons from Compound, remove the old ones.
Motivation and context
Story: element-hq/element-meta#2182
Screenshots / GIFs
Tests
Tested devices
Checklist