Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emojis in the bottom sheet are very tiny #2066

Closed
amshakal opened this issue Dec 19, 2023 · 4 comments · Fixed by #2074
Closed

Emojis in the bottom sheet are very tiny #2066

amshakal opened this issue Dec 19, 2023 · 4 comments · Fixed by #2074
Assignees
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@amshakal
Copy link

Steps to reproduce

Go to a room and long press a message bubble, a bottom sheet will pop up, select add a reaction -> a new bottom sheet is pop up

Outcome

The emojis should be be 5 in a row, not 7. The current tapping area is smaller than expected.

Your phone model

No response

Operating system version

No response

Application version and app store

No response

Homeserver

No response

Will you send logs?

Yes

Are you willing to provide a PR?

Yes

@amshakal amshakal added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Dec 19, 2023
@jmartinesp jmartinesp added S-Minor Impairs non-critical functionality or suitable workarounds exist O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience labels Dec 20, 2023
@jmartinesp jmartinesp self-assigned this Dec 20, 2023
@jmartinesp
Copy link
Member

jmartinesp commented Dec 20, 2023

The emojis should be be 5 in a row, not 7.

@amshakal Just to clarify: we're talking about what should appear in vertical orientation in the most commonly used resolution, not always using 5 items in a row, right? That could end up in weird situations like this one, where the emojis are gigantic:

image

@frebib
Copy link
Contributor

frebib commented Dec 20, 2023

The old (current master) behaviour seems to make more sense to me. Enforcing a number of columns is not a good way to go when you consider that different people have different display scaling settings. For me, there were 9 columns before as I run quite a small scale.
Can we stick with the old behaviour, but just increase the emoji size?

@jmartinesp
Copy link
Member

jmartinesp commented Dec 20, 2023

@amshakal just pinging you in case you didn't see the mention above (it was added when editing the message, so maybe there was no notification). Given the results in #2074 and the input from @bmarty and users as @frebib, do you think we should set a fixed column count, or is it ok with just increasing the emoji size as is done in that PR?

@amshakal
Copy link
Author

Hey I think increasing the size makes more sense, given the discussion, I forget we dont have control over all phono sizes. Im happy with #2074. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-Frequent Affects or can be seen by most users regularly or impacts most users' first experience S-Minor Impairs non-critical functionality or suitable workarounds exist T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants