Enable Chat backup, Mentions and Read Receipt in release. #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📱 Scan the QR code below to install the build (arm64 only) for this PR. |
|
I need to fix the test |
Also change default for debug to enabled, but keep `isFinished = false` for now, so that they are still disableable.
bmarty
force-pushed
the
feature/bma/enablechatBackup
branch
from
7868f8e
to
6ff48c2
Compare
|
|
Note: I ignore failing test in release |
bmarty
added
the
Run-Maestro
github-actions
bot
removed
the
Run-Maestro
jmartinesp
approved these changes
Dec 21, 2023
Comment on lines
+908
to
+912
| private suspend fun <T> ReceiveTurbine<T>.awaitFirstItem(): T { | ||
| // Skip 2 item if Mentions feature is enabled, else 1 | ||
| skipItems(if (FeatureFlags.Mentions.defaultValue) 2 else 1) | ||
| return awaitItem() | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also change default for debug to enabled, but keep
isFinished = falsefor now, so that they are still disableable.Type of change
Content
Motivation and context
Screenshots / GIFs
Tests
Tested devices
Checklist